You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/08/17 20:59:22 UTC
[GitHub] [parquet-mr] theosib-amazon opened a new pull request, #986: Prevent IntelliJ from making unsolicited whitespace changes
theosib-amazon opened a new pull request, #986:
URL: https://github.com/apache/parquet-mr/pull/986
Every time I make a PR on this project, I get a whole bunch of complaints about superfluous whitespace changes that I have to manually revert. Those changes are caused by a flag in .editorconfig called trim_trailing_whitespace. By removing this flag, we should stop seeing those complaints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #986: Prevent IntelliJ from making unsolicited whitespace changes
Posted by GitBox <gi...@apache.org>.
shangxinli commented on PR #986:
URL: https://github.com/apache/parquet-mr/pull/986#issuecomment-1221602126
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] parthchandra commented on pull request #986: Prevent IntelliJ from making unsolicited whitespace changes
Posted by GitBox <gi...@apache.org>.
parthchandra commented on PR #986:
URL: https://github.com/apache/parquet-mr/pull/986#issuecomment-1218501682
I think one needs this also - https://www.jetbrains.com/help/idea/reformat-and-rearrange-code.html#keep_existing_formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] theosib-amazon commented on pull request #986: Prevent IntelliJ from making unsolicited whitespace changes
Posted by GitBox <gi...@apache.org>.
theosib-amazon commented on PR #986:
URL: https://github.com/apache/parquet-mr/pull/986#issuecomment-1218488123
@parthchandra This might be the cause of the problem we were encountering with the whitespace changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli merged pull request #986: Prevent IntelliJ from making unsolicited whitespace changes
Posted by GitBox <gi...@apache.org>.
shangxinli merged PR #986:
URL: https://github.com/apache/parquet-mr/pull/986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org