You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/14 13:22:23 UTC

[GitHub] [flink] sunjincheng121 opened a new pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

sunjincheng121 opened a new pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…
URL: https://github.com/apache/flink/pull/8439
 
 
   ## What is the purpose of the change
   
   After FLINK-12407 Python Table API will align with current Java Table API. So, In the following Table API development, it's better to add a new user interface to the Java Table API will also need to be added to the Python Table API. So In this Jira, we want to add the test_completeness to check the user interface of Python Table API aligns with Java Table API. 
   
   I'm not sure if we want to force contributors to contribute to the Python Table API while developing the Java Table API. But at least we should have the ability to automatically check if Python is aligned with Java functionality.
   
   ## Brief change log
     -  Add `PythonAPICompletenessTestCase` which is base class for Python API completeness tests.
     - Add `TableAPICompletenessTests` which test whether the Python `Table` is consistent with Java `org.apache.flink.table.api.Table`.
     - Add `EnvironmentAPICompletenessTests` which test whether the Python `TableEnvironment` is consistent with Java `org.apache.flink.table.api.TableEnvironment`.
   
   ## Verifying this change
   This change is only adding the test case.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  (no)
     - If yes, how is the feature documented? (not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services