You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/05 02:36:08 UTC
[GitHub] [commons-lang] Arav1229 opened a new pull request, #930: Fixed incorrect documentation
Arav1229 opened a new pull request, #930:
URL: https://github.com/apache/commons-lang/pull/930
Methods throw null pointer exception but the javadocs did not reflect it. Fixed javadocs to address the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #930: Fixed incorrect documentation
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #930: Fixed incorrect documentation
URL: https://github.com/apache/commons-lang/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #930: Fixed incorrect documentation
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #930:
URL: https://github.com/apache/commons-lang/pull/930#discussion_r940159023
##########
src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java:
##########
@@ -100,6 +100,7 @@
* test is enabled and returns true. The result of this test
* is never changed throughout the life of this {@link DiffBuilder}.
* @throws IllegalArgumentException
+ * @throws NullPointerException
Review Comment:
Indentation does not seem to match what's above.
##########
src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java:
##########
@@ -352,7 +352,8 @@ public static int reflectionHashCode(final int initialNonZeroOddNumber, final in
* if the Object is {@code null}
* @throws IllegalArgumentException
* if the number is zero or even
- *
+ * @throws NullPointerException
+ * if the Object is {@code null}
Review Comment:
Indentation does not seem to match what's above. Name the parameter, not a generic type like Object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #930: Fixed incorrect documentation
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #930:
URL: https://github.com/apache/commons-lang/pull/930#issuecomment-1468048696
No reply, closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #930: Fixed incorrect documentation
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #930:
URL: https://github.com/apache/commons-lang/pull/930#issuecomment-1229244287
I'm not sure we should document this, otherwise, most if not all APIs would need to say they can throw NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org