You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2011/10/18 01:45:49 UTC
svn commit: r1185433 -
/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ExceptionAnalyzerImpl.java
Author: hlship
Date: Mon Oct 17 23:45:48 2011
New Revision: 1185433
URL: http://svn.apache.org/viewvc?rev=1185433&view=rev
Log:
TAP5-508: Exception reports can over-zealously squash exceptions
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ExceptionAnalyzerImpl.java
Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ExceptionAnalyzerImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ExceptionAnalyzerImpl.java?rev=1185433&r1=1185432&r2=1185433&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ExceptionAnalyzerImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ExceptionAnalyzerImpl.java Mon Oct 17 23:45:48 2011
@@ -79,7 +79,7 @@ public class ExceptionAnalyzerImpl imple
* We want to filter out exceptions that do not provide any additional value. Additional value includes: an
* exception message not present in the containing exception or a property value not present in the containing
* exception. Also the first exception is always valued and the last exception (with the stack trace) is valued.
- *
+ *
* @param previousInfo
* @param info
* @return
@@ -92,6 +92,10 @@ public class ExceptionAnalyzerImpl imple
if (!info.getStackTrace().isEmpty())
return true;
+ // TAP5-508: This adds back in a large number of frames that used to be squashed.
+ if (!info.getClassName().equals(previousInfo.getClassName()))
+ return true;
+
if (!previousInfo.getMessage().contains(info.getMessage()))
return true;