You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/12/05 05:20:06 UTC
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23748
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
KUDU-3722 unit mismatch in ProceedWithFlush
MaintenanceManager's ProceedWithFlush function uses units inconsistent
with process_memory::UnderMemoryPressure when checking memory pressure:
soft_limit and pressure_threshold are treated as decimals (0–1)
while used_memory_percentage is a percentage (0–100). This causes
ProceedWithFlush to always return true once memory usage exceeds
memory_pressure_percentage, which is not the intended behavior
introduced by KUDU-3407.
This patch converts soft_limit and pressure_threshold to percentages,
replaces division with an equivalent multiplication form, and updates
the relevant tests.
Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Reviewed-on: http://gerrit.cloudera.org:8080/23726
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 6799d13cc53190604d141ca1ebf26882edb3b88a)
---
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
2 files changed, 23 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/23748/1
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23748 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2179/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 06:18:06 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23748 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
KUDU-3722 unit mismatch in ProceedWithFlush
MaintenanceManager's ProceedWithFlush function uses units inconsistent
with process_memory::UnderMemoryPressure when checking memory pressure:
soft_limit and pressure_threshold are treated as decimals (0–1)
while used_memory_percentage is a percentage (0–100). This causes
ProceedWithFlush to always return true once memory usage exceeds
memory_pressure_percentage, which is not the intended behavior
introduced by KUDU-3407.
This patch converts soft_limit and pressure_threshold to percentages,
replaces division with an equivalent multiplication form, and updates
the relevant tests.
Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Reviewed-on: http://gerrit.cloudera.org:8080/23726
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 6799d13cc53190604d141ca1ebf26882edb3b88a)
Reviewed-on: http://gerrit.cloudera.org:8080/23748
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
2 files changed, 23 insertions(+), 20 deletions(-)
Approvals:
Zoltan Martonka: Looks good to me, but someone else must approve
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23748 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 17:05:45 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23748 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2179/
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 05:20:14 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23748 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 05:38:12 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23748 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
Patch Set 1: Verified+1
unrelated failures of known flaky tests:
* DEBUG: KUDU-3591
* TSAN: KUDU-3660, org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 06:48:16 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3722 unit mismatch in ProceedWithFlush
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08
Gerrit-Change-Number: 23748
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yongheng Deng <76...@qq.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>