You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/22 13:32:33 UTC
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #178: [FOLLOWUP] [ISSUE-173] the size of single buffer flush should reach rss.server.flush.cold.storage.threshold.size
jerqi commented on code in PR #178:
URL: https://github.com/apache/incubator-uniffle/pull/178#discussion_r951445918
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -165,7 +165,9 @@ public ShuffleDataResult getShuffleData(
void flushSingleBufferIfNecessary(ShuffleBuffer buffer, String appId,
int shuffleId, int startPartition, int endPartition) {
- if (this.bufferFlushEnabled && buffer.getSize() >= this.bufferFlushThreshold) {
+ // when single buffer flush is triggered, the buffer size should reach
Review Comment:
When we use multistorage and trigger single buffer flush, the buffer size should be bigger than `rss.server.flush.cold.storage.threshold.size`, otherwise old storage will be useless.
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -165,7 +165,9 @@ public ShuffleDataResult getShuffleData(
void flushSingleBufferIfNecessary(ShuffleBuffer buffer, String appId,
int shuffleId, int startPartition, int endPartition) {
- if (this.bufferFlushEnabled && buffer.getSize() >= this.bufferFlushThreshold) {
+ // when single buffer flush is triggered, the buffer size should reach
Review Comment:
When we use multistorage and trigger single buffer flush, the buffer size should be bigger than `rss.server.flush.cold.storage.threshold.size`, otherwise cold storage will be useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org