[GitHub] [maven-surefire] sbabcoc commented on pull request #528: SUREFIRE-2075: Only set thread count if specified in configuration

[GitBox <gi...@apache.org>]

sbabcoc commented on PR #528:
URL: https://github.com/apache/maven-surefire/pull/528#issuecomment-1117550351

   @Tibor17 With the revisions in this PR, the ASF TestNG implementation will exhibit the behavior you've described.
   * With no value specified for the [parallel] setting, tests execute sequentially on a single thread.
   * If any valid value is specified for the [parallel] setting (other than `none`), tests execute in parallel...
     *  ... on 5 threads if the [threadCount] setting is unspecified (as indicated by the ASF documentation).
     * ... on [threadCount] threads if a valid integer value is specified for this setting.
   
   Without the revisions in this PR, tests always execute sequentially unless valid values are provided for both [parallel] and [threadCount]. Specifying [parallel] by itself is insufficient to activate parallel execution behavior. This contradicts the ASF documentation and alters the execution behavior exhibited natively by TestNG or in other test harnesses (e.g. - Gradle).
   
   The revisions in this PR resolve the issue of default [threadCount] value and always provide parallel execution behavior when [parallel] is specified. It also emits an actionable error message if an invalid value is specified for [threadCount], instead of the naked **NumberFormatException** that is currently produced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org