You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/03/08 07:17:06 UTC
[GitHub] [commons-beanutils] chrismaeda opened a new pull request #81: 1.x upgrade commons-collections to 4.4
chrismaeda opened a new pull request #81:
URL: https://github.com/apache/commons-beanutils/pull/81
I merged the changes in master since beanutils 1.9.4, through commons-collections 4.4.
I stopped there because it looked like removing commons-collections 4 (BEANUTILS-527) also required java 8 language features.
I was also unclear about whether to merge Jira509TestCase (BEANUTILS-509).
'mvn test' passes with java 8.
Feedback appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory commented on pull request #81: 1.x upgrade commons-collections to 4.4
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #81:
URL: https://github.com/apache/commons-beanutils/pull/81#issuecomment-792724207
> I merged the changes in master since beanutils 1.9.4, through commons-collections 4.4.
>
> I stopped there because it looked like removing commons-collections 4 (BEANUTILS-527) also required java 8 language features.
>
> I was also unclear about whether to merge Jira509TestCase (BEANUTILS-509).
>
> 'mvn test' passes with java 8.
>
> Feedback appreciated.
-1 as this breaks binary compatibility, 2.0-SNAPSHOT is on Collections 4.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] chrismaeda closed pull request #81: 1.x upgrade commons-collections to 4.4
Posted by GitBox <gi...@apache.org>.
chrismaeda closed pull request #81:
URL: https://github.com/apache/commons-beanutils/pull/81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] chrismaeda commented on pull request #81: 1.x upgrade commons-collections to 4.4
Posted by GitBox <gi...@apache.org>.
chrismaeda commented on pull request #81:
URL: https://github.com/apache/commons-beanutils/pull/81#issuecomment-792942237
Ok. Sorry to keep wasting your time. I found your blog post explaining the binary compatibility requirements...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory commented on pull request #81: 1.x upgrade commons-collections to 4.4
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #81:
URL: https://github.com/apache/commons-beanutils/pull/81#issuecomment-793066162
You can run 'mvn clirr:check' on some of our older components to see for yourself. Newer components use japicmp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org