[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #468: apps/btshell: Update conn-datalen params help to be more informative

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #468: apps/btshell: Update conn-datalen params help to be more informative
URL: https://github.com/apache/mynewt-nimble/pull/468#discussion_r291649890
 
 

 ##########
 File path: apps/btshell/src/cmd.c
 ##########
 @@ -2203,9 +2203,11 @@ cmd_conn_datalen(int argc, char **argv)
 
 #if MYNEWT_VAL(SHELL_CMD_HELP)
 static const struct shell_param conn_datalen_params[] = {
-    {"conn", "conn_datalen handle, usage: =<UINT16>"},
-    {"octets", "usage: =<UINT16>"},
-    {"time", "usage: =<UINT16>"},
+    {"conn", "Connection handle, usage: =<UINT16>"},
+    {"octets", "Max payload size to include in LL Data PDU, "
+               "range=<0x001B-0x00FB>, usage: =<UINT16>"},
+    {"time", "Max number of microseconds the controller should use to tx "
+             "single LL packet, range=<0x0148-0x4290>, usage: =<UINT16>"},
 
 Review comment:
   and here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services