You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Paul Elschot (JIRA)" <ji...@apache.org> on 2009/08/24 21:36:59 UTC

[jira] Created: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

'ant javacc' in root project should also properly create contrib/surround Java files
------------------------------------------------------------------------------------

                 Key: LUCENE-1851
                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
             Project: Lucene - Java
          Issue Type: Improvement
          Components: contrib/*
    Affects Versions: 3.1
            Reporter: Paul Elschot
            Assignee: Paul Elschot
            Priority: Minor
             Fix For: 3.1


For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747884#action_12747884 ] 

Paul Elschot commented on LUCENE-1851:
--------------------------------------

After svn update I still have the output below, so I think the commit missed some files affected by the patch:

svn diff `find contrib/surround -name '*.jj'`

Index: contrib/surround/src/java/org/apache/lucene/queryParser/surround/parser/QueryParser.jj
===================================================================
--- contrib/surround/src/java/org/apache/lucene/queryParser/surround/parser/QueryParser.jj	(revision 807956)
+++ contrib/surround/src/java/org/apache/lucene/queryParser/surround/parser/QueryParser.jj	(working copy)
@@ -184,7 +184,7 @@
 }
 
 <DEFAULT> SKIP : {
-  <<_WHITESPACE>>
+  < <_WHITESPACE>>
 }
 
 /* Operator tokens (in increasing order of precedence): */


> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luis Alves updated LUCENE-1851:
-------------------------------

    Attachment: LUCENE-1851.patch

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 3.1
>            Reporter: Paul Elschot
>            Assignee: Paul Elschot
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Elschot updated LUCENE-1851:
---------------------------------

    Attachment: javacc20090825.patch

I've meanwhile switched to ubuntu, and I had to install javacc, which was easy.
Then I still had to apply the attached patch for javacc to common-build.xml, and put the following line in ~/build.properties:
javacc.home=/usr/share/java

After that, these worked fine with the patch applied from contrib/surround:
ant clean
ant javacc
ant test

Since the patch does not change the tests of the surround parser the change to the .jj file still passed all the tests.

>From the top directory:
ant clean
ant javacc
ant test-contrib

also worked fine.

So, in all, this was a very nice excuse to reinstall javacc :)


> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch resolved LUCENE-1851.
-----------------------------------

    Resolution: Fixed

Fixed it. Sorry about that.

Committed revision 808224.

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luis Alves updated LUCENE-1851:
-------------------------------

    Lucene Fields: [New, Patch Available]  (was: [New])

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Luis Alves
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luis Alves updated LUCENE-1851:
-------------------------------

    Affects Version/s:     (was: 3.1)
                       2.9
        Fix Version/s:     (was: 3.1)
                       2.9

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Luis Alves
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747173#action_12747173 ] 

Luis Alves commented on LUCENE-1851:
------------------------------------

changes:
 - fixed jjdoc - removed StandardTokenizer.jj added /surround/parser/QueryParser.jj and StandardSyntaxParser.jj
 - fixed surround/build.xml to build javacc
 - fixed surround/.../QueryParser.jj small change to allow javacc to process the file
 - updated clean-javacc and javacc targets

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Luis Alves
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747961#action_12747961 ] 

Luis Alves commented on LUCENE-1851:
------------------------------------

{code}
javacc:
   [javacc] Java Compiler Compiler Version 4.2 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file /home/lafa/kisor2/workspace_eclipse33/lucene_trunk2/contrib/surround/src/java/org/apache/lucene/queryParser/surround/parser/QueryParser.jj . . .
   [javacc] org.javacc.parser.ParseException: Encountered " "<<" "<< "" at line 187, column 3.
   [javacc] Was expecting one of:
   [javacc]     <STRING_LITERAL> ...
   [javacc]     "<" ...
   [javacc]     
   [javacc] Detected 1 errors and 0 warnings.
{code}
I just re-synced and see the same problem, I think Michael forgot to commit the QueryParser.jj changes I made.


> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch resolved LUCENE-1851.
-----------------------------------

    Resolution: Fixed

Committed revision 807835.

Thanks for the patch, Luis, and for testing, Paul!

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Closed: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Elschot closed LUCENE-1851.
--------------------------------


Everything working as expected now. Thanks.

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747174#action_12747174 ] 

Luis Alves commented on LUCENE-1851:
------------------------------------

Hi Paul,

I found some time to write a patch for this :)
If you have time can you try my patch.

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Luis Alves
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Issue Comment Edited: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747571#action_12747571 ] 

Paul Elschot edited comment on LUCENE-1851 at 8/25/09 12:18 PM:
----------------------------------------------------------------

I've meanwhile switched to ubuntu, and I had to install javacc, which was easy.
Then I still had to apply the attached patch for javacc to common-build.xml, and put the following line in ~/build.properties:
javacc.home=/usr/share/java

After that, these worked fine with Luis' patch applied from contrib/surround:
ant clean
ant javacc
ant test

Since the patch does not change the tests of the surround parser the change to the .jj file still passed all the tests.

>From the top directory:
ant clean
ant javacc
ant test-contrib

also worked fine.

So, in all, this was a very nice excuse to reinstall javacc :)


      was (Author: paul.elschot@xs4all.nl):
    I've meanwhile switched to ubuntu, and I had to install javacc, which was easy.
Then I still had to apply the attached patch for javacc to common-build.xml, and put the following line in ~/build.properties:
javacc.home=/usr/share/java

After that, these worked fine with the patch applied from contrib/surround:
ant clean
ant javacc
ant test

Since the patch does not change the tests of the surround parser the change to the .jj file still passed all the tests.

>From the top directory:
ant clean
ant javacc
ant test-contrib

also worked fine.

So, in all, this was a very nice excuse to reinstall javacc :)

  
> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luis Alves reassigned LUCENE-1851:
----------------------------------

    Assignee: Luis Alves  (was: Paul Elschot)

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Luis Alves
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch reassigned LUCENE-1851:
-------------------------------------

    Assignee: Michael Busch  (was: Luis Alves)

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luis Alves updated LUCENE-1851:
-------------------------------

    Attachment:     (was: LUCENE-1851.patch)

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Paul Elschot
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747682#action_12747682 ] 

Michael Busch commented on LUCENE-1851:
---------------------------------------

Patch works fine for me too. Will commit soon.

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747146#action_12747146 ] 

Luis Alves commented on LUCENE-1851:
------------------------------------

Paul do you have time to create a patch file?
I'll review it and test it, if you don't have time let me know.

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 3.1
>            Reporter: Paul Elschot
>            Assignee: Paul Elschot
>            Priority: Minor
>             Fix For: 3.1
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luis Alves updated LUCENE-1851:
-------------------------------

    Attachment: LUCENE-1851.patch

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Paul Elschot
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Reopened: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files

Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Elschot reopened LUCENE-1851:
----------------------------------


Reopening only to make sure my last comment is not missed before the impending 2.9 release.

> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org