You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/04 19:58:26 UTC
[GitHub] [geode] sabbeyPivotal opened a new pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
sabbeyPivotal opened a new pull request #5214:
URL: https://github.com/apache/geode/pull/5214
Update documentation to match changes in Redis API for Geode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on pull request #5214:
URL: https://github.com/apache/geode/pull/5214#issuecomment-640788036
The DistributedTestOpenJDK11 test failure is unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r436181874
##########
File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb
##########
@@ -2197,6 +2197,9 @@ gfsh</a>
<li>
<a href="/docs/guide/<%=vars.product_version_nodot%>/tools_modules/redis_api_for_geode.html#advantages-of-<%=vars.product_name_lowercase%>-over-redis">Advantages of <%=vars.product_name%> over Redis</a>
Review comment:
Not part of this PR, but a potential problem. We use template variables to allow portability to other products that use the geode open-source repo. Use in section names (such as "Advantages of <%=vars.product_name%>..." follows this intention. However, use in target ids (such as "#advantages-of-<%=vars.product_name_lowercase%>-over-redis") defeats the purpose, as the links are almost certainly guaranteed to fail in other contexts. The hash tags should be genericized, for example "advantages-over-redis".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435537613
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
Review comment:
Redis groups it with other Server commands: https://redis.io/commands#server
Should we use the same grouping as Redis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435537184
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
+- **Connection**: ECHO, TIME, SHUTDOWN
Review comment:
No, we were going through how Redis groups them and forgot to remove them. Just updated it! Thanks for finding that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435549141
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
Review comment:
looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435537184
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
+- **Connection**: ECHO, TIME, SHUTDOWN
Review comment:
No, we were going though how Redis groups them and forgot to remove them. Just updated it! Thanks for finding that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435518492
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
+- **Connection**: ECHO, TIME, SHUTDOWN
Review comment:
did you intend to mention ECHO, TIME, and SHUTDOWN twice (once in Server once in Connection)?
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
Review comment:
DBSIZE makes more sense to be in the "Keys" section since it tells you how many keys exist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r436178644
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,52 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+**Note**: These commands are supported for Redis 5.
+
+- **Connection**: AUTH, PING, QUIT
- **Hashes**: HGETALL, HMSET, HSET
-- **Sets**: SADD, SMEMBERS, SREM
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Sets**: SADD, SMEMBERS, SREM
+- **Strings**: APPEND, GET, SET
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**. Unsupported
+commands are available to use, but have not been fully tested. There is no guarantee they will work
+exactly as expected.
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Connection**: ECHO
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
+- **Keys**: SCAN
+- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+
+
+To enable unsupported commands, the Geode server must be started with the Java property `enable-redis-unsupported-commands=true`:
+
+```pre
+start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=<serverName> \
+ --locators=<locatorPort> \
+ --redis-port=<redisPort> \
+ --redis-bind-address=<redisBindAddress> \
+ --redis-password=<redisPassword>
+```
+
+Commands not listed above are **not implemented**.
## <a id="advantages-of-<%=vars.product_name_lowercase%>-over-redis" class="no-quick-link"></a>Advantages of <%=vars.product_name%> over Redis
<%=vars.product_name%>’s primary advantage is its **scalability**. While the Redis server is single threaded, <%=vars.product_name%> supports high concurrency. Many Redis clients can execute commands on the <%=vars.product_name%> cluster simultaneously.
-<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client.
\ No newline at end of file
+<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client.
+
+## <a id="expiration-accuracy" class="no-quick-link"></a>Expiration Accuracy
+
+Keys are expired in two ways, actively and passively:
+
+- Expiration is evaluated whenever a key is accessed. If the key is due to expire, it is deleted. Active expiration is accurate to the millisecond.
Review comment:
For clarity, please begin each bullet with the type of expiration it explains. A bit more stilted, stylistic, but worth it I think for ease of apprehension. Something like this:
- With active expiration, expiration is evaluated..
- With passive expiration, keys are evaluated every second...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435540027
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
Review comment:
Just realizing we need to move FLUSHALL and FLUSHDB as well since Redis groups them with the Server commands
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r436181874
##########
File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb
##########
@@ -2197,6 +2197,9 @@ gfsh</a>
<li>
<a href="/docs/guide/<%=vars.product_version_nodot%>/tools_modules/redis_api_for_geode.html#advantages-of-<%=vars.product_name_lowercase%>-over-redis">Advantages of <%=vars.product_name%> over Redis</a>
Review comment:
Not part of this PR, but a potential problem. We use template variables to allow portability to other products that use the geode open-source repo. Use in section names (such as "Advantages of <%=vars.product_name%>..." follows this intention. However, use in target ids (such as "#advantages-of-<%=vars.product_name_lowercase%>-over-redis") defeats the purpose, as the links are almost certainly guaranteed to fail in other contexts. The anchor tags should be genericized, for example "advantages-over-redis".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5214:
URL: https://github.com/apache/geode/pull/5214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r436181874
##########
File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb
##########
@@ -2197,6 +2197,9 @@ gfsh</a>
<li>
<a href="/docs/guide/<%=vars.product_version_nodot%>/tools_modules/redis_api_for_geode.html#advantages-of-<%=vars.product_name_lowercase%>-over-redis">Advantages of <%=vars.product_name%> over Redis</a>
Review comment:
Not part of this PR, but a potential problem. We use template variables to allow portability to other products that use the geode open-source repo. Use in section names (such as "Advantages of <%=vars.product_name%>..." follows this intention. However, use in target ids (such as "#advantages-of-<%=vars.product_name_lowercase%>-over-redis") defeats the purpose, as the links are almost certainly guaranteed to fail in other contexts. The hash tags should be genericized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r436178644
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,52 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+**Note**: These commands are supported for Redis 5.
+
+- **Connection**: AUTH, PING, QUIT
- **Hashes**: HGETALL, HMSET, HSET
-- **Sets**: SADD, SMEMBERS, SREM
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Sets**: SADD, SMEMBERS, SREM
+- **Strings**: APPEND, GET, SET
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**. Unsupported
+commands are available to use, but have not been fully tested. There is no guarantee they will work
+exactly as expected.
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Connection**: ECHO
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
+- **Keys**: SCAN
+- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+
+
+To enable unsupported commands, the Geode server must be started with the Java property `enable-redis-unsupported-commands=true`:
+
+```pre
+start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=<serverName> \
+ --locators=<locatorPort> \
+ --redis-port=<redisPort> \
+ --redis-bind-address=<redisBindAddress> \
+ --redis-password=<redisPassword>
+```
+
+Commands not listed above are **not implemented**.
## <a id="advantages-of-<%=vars.product_name_lowercase%>-over-redis" class="no-quick-link"></a>Advantages of <%=vars.product_name%> over Redis
<%=vars.product_name%>’s primary advantage is its **scalability**. While the Redis server is single threaded, <%=vars.product_name%> supports high concurrency. Many Redis clients can execute commands on the <%=vars.product_name%> cluster simultaneously.
-<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client.
\ No newline at end of file
+<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client.
+
+## <a id="expiration-accuracy" class="no-quick-link"></a>Expiration Accuracy
+
+Keys are expired in two ways, actively and passively:
+
+- Expiration is evaluated whenever a key is accessed. If the key is due to expire, it is deleted. Active expiration is accurate to the millisecond.
Review comment:
For clarity, please begin each bullet with the type of expiration it explains. A bit more stilted, stylistically, but worth it I think for ease of apprehension. Something like this:
- With active expiration, expiration is evaluated..
- With passive expiration, keys are evaluated every second...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435542776
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
Review comment:
I just reorganized them, please double check though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5214: GEODE-8223: Update expiration implementation as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r435541018
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,47 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+- **Strings**: APPEND, GET, SET
- **Hashes**: HGETALL, HMSET, HSET
- **Sets**: SADD, SMEMBERS, SREM
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
+- **Connection**: AUTH, PING, QUIT
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**:
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Keys**: FLUSHALL (no async option), FLUSHDB (no async option), SCAN
+- **Server**: DBSIZE, ECHO, TIME, SHUTDOWN
Review comment:
I agree that we should follow redis's grouping. I had not even noticed that redis had the "filter by group" drop down.
So: FLUSHALL and FLUSHDB are also in the "Server" group. So that leaves just SCAN in our unsupported "Keys" group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r436710499
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -60,30 +65,52 @@ If the server is functioning properly, you should see a response of `PONG`.
The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
-- **Strings**: APPEND, GET, GETRANGE, SET
+**Note**: These commands are supported for Redis 5.
+
+- **Connection**: AUTH, PING, QUIT
- **Hashes**: HGETALL, HMSET, HSET
-- **Sets**: SADD, SMEMBERS, SREM
+- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE
- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME
+- **Sets**: SADD, SMEMBERS, SREM
+- **Strings**: APPEND, GET, SET
-The following Redis API for <%=vars.product_name%> commands are **experimental**:
+The following Redis API for <%=vars.product_name%> commands are **unsupported**. Unsupported
+commands are available to use, but have not been fully tested. There is no guarantee they will work
+exactly as expected.
-- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
- MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN
-- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX
-- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS
+- **Connection**: ECHO
+- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS
+- **Keys**: SCAN
+- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
SSCAN, SUNION, SUNIONSTORE
-- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE,
- ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE,
- ZREVRANK, ZSCAN, ZSCORE
-- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE
-- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL
-- **Transactions**: DISCARD, EXEC, MULTI
-- **Server**: AUTH, ECHO, PING, QUIT
+- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET,
+ MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN
+
+
+To enable unsupported commands, the Geode server must be started with the Java property `enable-redis-unsupported-commands=true`:
+
+```pre
+start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=<serverName> \
+ --locators=<locatorPort> \
+ --redis-port=<redisPort> \
+ --redis-bind-address=<redisBindAddress> \
+ --redis-password=<redisPassword>
+```
+
+Commands not listed above are **not implemented**.
## <a id="advantages-of-<%=vars.product_name_lowercase%>-over-redis" class="no-quick-link"></a>Advantages of <%=vars.product_name%> over Redis
<%=vars.product_name%>’s primary advantage is its **scalability**. While the Redis server is single threaded, <%=vars.product_name%> supports high concurrency. Many Redis clients can execute commands on the <%=vars.product_name%> cluster simultaneously.
-<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client.
\ No newline at end of file
+<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client.
+
+## <a id="expiration-accuracy" class="no-quick-link"></a>Expiration Accuracy
+
+Keys are expired in two ways, actively and passively:
+
+- Expiration is evaluated whenever a key is accessed. If the key is due to expire, it is deleted. Active expiration is accurate to the millisecond.
Review comment:
Just updated it!
##########
File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb
##########
@@ -2197,6 +2197,9 @@ gfsh</a>
<li>
<a href="/docs/guide/<%=vars.product_version_nodot%>/tools_modules/redis_api_for_geode.html#advantages-of-<%=vars.product_name_lowercase%>-over-redis">Advantages of <%=vars.product_name%> over Redis</a>
Review comment:
I went ahead and updated it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org