You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/07/10 15:49:19 UTC
Review Request: Adding tags support to the 4 EC2 Describe* API's
(DescribeImages, DescribeInstances, DescribeVolumes,
DescribeSnapshots) in AWSAPI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5885/
-----------------------------------------------------------
Review request for cloudstack and Prachi Damle.
Description
-------
List* APIs in CloudStack have tags support. Adding the corresponding support to EC2Decsribe* APIs in the AWSAPI component.
Diffs
-----
awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 9e10e09
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 5f45847
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Image.java 75e792b
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Instance.java 064d7e0
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Snapshot.java 339506d
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Volume.java 009c17a
awsapi/src/com/cloud/stack/models/CloudStackSnapshot.java 73dc4cd
awsapi/src/com/cloud/stack/models/CloudStackTemplate.java 14d6e82
awsapi/src/com/cloud/stack/models/CloudStackUserVm.java f72e1b6
awsapi/src/com/cloud/stack/models/CloudStackVolume.java 13d87f4
Diff: https://reviews.apache.org/r/5885/diff/
Testing
-------
Thanks,
Likitha Shetty
Re: Review Request: Adding tags support to the 4 EC2 Describe* API's
(DescribeImages, DescribeInstances, DescribeVolumes,
DescribeSnapshots) in AWSAPI
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5885/#review9098
-----------------------------------------------------------
Changes are good. I will apply this patch after the licensing in earlier patch#5802 is corrected and applied.
- Prachi Damle
On July 10, 2012, 1:49 p.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5885/
> -----------------------------------------------------------
>
> (Updated July 10, 2012, 1:49 p.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> List* APIs in CloudStack have tags support. Adding the corresponding support to EC2Decsribe* APIs in the AWSAPI component.
>
>
> Diffs
> -----
>
> awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 9e10e09
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 5f45847
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Image.java 75e792b
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Instance.java 064d7e0
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Snapshot.java 339506d
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Volume.java 009c17a
> awsapi/src/com/cloud/stack/models/CloudStackSnapshot.java 73dc4cd
> awsapi/src/com/cloud/stack/models/CloudStackTemplate.java 14d6e82
> awsapi/src/com/cloud/stack/models/CloudStackUserVm.java f72e1b6
> awsapi/src/com/cloud/stack/models/CloudStackVolume.java 13d87f4
>
> Diff: https://reviews.apache.org/r/5885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request: Adding tags support to the 4 EC2 Describe* API's
(DescribeImages, DescribeInstances, DescribeVolumes,
DescribeSnapshots) in AWSAPI
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5885/#review9379
-----------------------------------------------------------
Ship it!
Ship It!
- Prachi Damle
On July 10, 2012, 1:49 p.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5885/
> -----------------------------------------------------------
>
> (Updated July 10, 2012, 1:49 p.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> List* APIs in CloudStack have tags support. Adding the corresponding support to EC2Decsribe* APIs in the AWSAPI component.
>
>
> Diffs
> -----
>
> awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 9e10e09
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 5f45847
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Image.java 75e792b
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Instance.java 064d7e0
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Snapshot.java 339506d
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Volume.java 009c17a
> awsapi/src/com/cloud/stack/models/CloudStackSnapshot.java 73dc4cd
> awsapi/src/com/cloud/stack/models/CloudStackTemplate.java 14d6e82
> awsapi/src/com/cloud/stack/models/CloudStackUserVm.java f72e1b6
> awsapi/src/com/cloud/stack/models/CloudStackVolume.java 13d87f4
>
> Diff: https://reviews.apache.org/r/5885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Likitha Shetty
>
>