You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2018/02/20 13:51:34 UTC
spark git commit: [SPARK-23383][BUILD][MINOR] Make a distribution
should exit with usage while detecting wrong options
Repository: spark
Updated Branches:
refs/heads/master 862fa697d -> 189f56f3d
[SPARK-23383][BUILD][MINOR] Make a distribution should exit with usage while detecting wrong options
## What changes were proposed in this pull request?
```shell
./dev/make-distribution.sh --name ne-1.0.0-SNAPSHOT xyz --tgz -Phadoop-2.7
+++ dirname ./dev/make-distribution.sh
++ cd ./dev/..
++ pwd
+ SPARK_HOME=/Users/Kent/Documents/spark
+ DISTDIR=/Users/Kent/Documents/spark/dist
+ MAKE_TGZ=false
+ MAKE_PIP=false
+ MAKE_R=false
+ NAME=none
+ MVN=/Users/Kent/Documents/spark/build/mvn
+ (( 5 ))
+ case $1 in
+ NAME=ne-1.0.0-SNAPSHOT
+ shift
+ shift
+ (( 3 ))
+ case $1 in
+ break
+ '[' -z /Users/Kent/.jenv/candidates/java/current ']'
+ '[' -z /Users/Kent/.jenv/candidates/java/current ']'
++ command -v git
+ '[' /usr/local/bin/git ']'
++ git rev-parse --short HEAD
+ GITREV=98ea6a7
+ '[' '!' -z 98ea6a7 ']'
+ GITREVSTRING=' (git revision 98ea6a7)'
+ unset GITREV
++ command -v /Users/Kent/Documents/spark/build/mvn
+ '[' '!' /Users/Kent/Documents/spark/build/mvn ']'
++ /Users/Kent/Documents/spark/build/mvn help:evaluate -Dexpression=project.version xyz --tgz -Phadoop-2.7
++ grep -v INFO
++ tail -n 1
+ VERSION=' -X,--debug Produce execution debug output'
```
It is better to declare the mistakes and exit with usage than `break`
## How was this patch tested?
manually
cc srowen
Author: Kent Yao <ya...@hotmail.com>
Closes #20571 from yaooqinn/SPARK-23383.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/189f56f3
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/189f56f3
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/189f56f3
Branch: refs/heads/master
Commit: 189f56f3dcdad4d997248c01aa5490617f018bd0
Parents: 862fa69
Author: Kent Yao <ya...@hotmail.com>
Authored: Tue Feb 20 07:51:30 2018 -0600
Committer: Sean Owen <so...@cloudera.com>
Committed: Tue Feb 20 07:51:30 2018 -0600
----------------------------------------------------------------------
dev/make-distribution.sh | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/189f56f3/dev/make-distribution.sh
----------------------------------------------------------------------
diff --git a/dev/make-distribution.sh b/dev/make-distribution.sh
index 8b02446..84233c6 100755
--- a/dev/make-distribution.sh
+++ b/dev/make-distribution.sh
@@ -72,9 +72,17 @@ while (( "$#" )); do
--help)
exit_with_usage
;;
- *)
+ --*)
+ echo "Error: $1 is not supported"
+ exit_with_usage
+ ;;
+ -*)
break
;;
+ *)
+ echo "Error: $1 is not supported"
+ exit_with_usage
+ ;;
esac
shift
done
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org