You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 15:36:53 UTC

[GitHub] [airflow] kishvanchee commented on a change in pull request #11277: Move dagrun_operator.py to dagrun.py (#11178)

kishvanchee commented on a change in pull request #11277:
URL: https://github.com/apache/airflow/pull/11277#discussion_r499690924



##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -15,88 +15,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+"""This module is deprecated. Please use `airflow.operators.dagrun`."""
 
-import datetime
-from typing import Dict, Optional, Union
-from urllib.parse import quote
+import warnings
 
-from airflow.api.common.experimental.trigger_dag import trigger_dag
-from airflow.models import BaseOperator, BaseOperatorLink, DagRun
-from airflow.utils import timezone
-from airflow.utils.decorators import apply_defaults
-from airflow.utils.types import DagRunType
+# pylint: disable=unused-import
+from airflow.operators.dagrun import TriggerDagRunOperator # noqa
 
-
-class TriggerDagRunLink(BaseOperatorLink):

Review comment:
       Got it. Just noticed. I guess I didn't read the conflict properly although when I was working on it the particular `class TriggerDagRunLink(BaseOperatorLink)` didn't exist in the file. I'll fix this now.
   
   Please correct me if I'm wrong, so to fix this, I should finish working on the file, fetch/rebase, then push again. Right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org