You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:41:47 UTC

[GitHub] [incubator-superset] riahk opened a new pull request #10439: [WIP] style: Move security/manage navigation tabs into a settings dropdown

riahk opened a new pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439


   ### SUMMARY
   - [x] Adds settings dropdown in top-right corner
   - [x] Move Security/Manage menu options into settings dropdown
   - [ ] Move 'Import Dashboard(s)' to a button next to Bulk Select on Dashboards page
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before (Also applies to FAB pages):
   <img width="1162" alt="Screen Shot 2020-07-27 at 12 35 31 PM" src="https://user-images.githubusercontent.com/8216382/88584235-31aca280-d006-11ea-924d-1ddc88bc16d0.png">
   
   After:
   <img width="1163" alt="Screen Shot 2020-07-27 at 12 37 32 PM" src="https://user-images.githubusercontent.com/8216382/88584269-3ec99180-d006-11ea-96e6-832b9f4ede61.png">
   
   ### TEST PLAN
   - [x] Added settings dropdown check to `Menu_spec.jsx`
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai edited a comment on pull request #10439: [WIP] style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

nytai edited a comment on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-676545283


   This is currently blocked by the pr that switches to using the react menu exclusively: https://github.com/apache/incubator-superset/pull/10401 
   
   That PR is blocked by my limited understanding of how the public role works (or doesn't work) in superset.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] riahk commented on pull request #10439: [WIP] style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

riahk commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-676555034


   @mistercrunch I very much plan on getting this merged in! As Tai mentioned, we're waiting until superset is only using the react menu. I'll update the description to make this clearer and link the related PR 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai removed a comment on pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

nytai removed a comment on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-681163046


   @riahk could you also update the screenshots, I think the menu has changed a fair amount 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai merged pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

nytai merged pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai closed pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

nytai closed pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #10439: [WIP] style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

nytai commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-676545283


   This is currently blocked by the pr that switches to using the react menu exclusively. https://github.com/apache/incubator-superset/pull/10401 
   
   That PR is blocked by my limited understanding of how the public role works (or doesn't work) in superset.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-681123838


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10439?src=pr&el=h1) Report
   > Merging [#10439](https://codecov.io/gh/apache/incubator-superset/pull/10439?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a95e5c9327738489fd9fb547134f7ff4ea8c37af?el=desc) will **decrease** coverage by `4.22%`.
   > The diff coverage is `37.25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10439/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10439?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10439      +/-   ##
   ==========================================
   - Coverage   64.43%   60.21%   -4.23%     
   ==========================================
     Files         785      785              
     Lines       36987    37030      +43     
     Branches     3530     3544      +14     
   ==========================================
   - Hits        23833    22296    -1537     
   - Misses      13045    14547    +1502     
   - Partials      109      187      +78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `60.85% <37.25%> (-0.07%)` | :arrow_down: |
   | #python | `59.82% <ø> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10439?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `86.66% <ø> (ø)` | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `73.68% <50.00%> (-0.32%)` | :arrow_down: |
   | [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `91.83% <90.00%> (-1.50%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [145 more](https://codecov.io/gh/apache/incubator-superset/pull/10439/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10439?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10439?src=pr&el=footer). Last update [a95e5c9...4c397af](https://codecov.io/gh/apache/incubator-superset/pull/10439?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10439: [WIP] style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

mistercrunch commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-675861469


   Is this abandoned? :(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

mistercrunch commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-680102868


   https://github.com/apache/incubator-superset/pull/10401 has been merged, please rebase!
   
   Also note that https://github.com/apache/incubator-superset/pull/10423 just got merged and may create conflicts with this. Let us know if you need help untangling some of this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10439: [WIP] style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

willbarrett commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-676535361


   @riahk this needs another commit to re-trigger CI since the required checks have changed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

willbarrett commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-681161021


   @riahk unfortunately this needs another rebase :(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

nytai commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-681163582


   oops, sorry for closing. Also sorry for requiring another rabse, I just merged https://github.com/apache/incubator-superset/pull/10680


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #10439: style: Move security/manage navigation tabs into a settings dropdown

Posted by GitBox <gi...@apache.org>.

nytai commented on pull request #10439:
URL: https://github.com/apache/incubator-superset/pull/10439#issuecomment-681163046


   @riahk could you also update the screenshots, I think the menu has changed a fair amount 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org