You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/04/03 02:31:19 UTC

[GitHub] spark pull request: [SQL][SPARK-4226]: Add support for subqueries ...

Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/3888#issuecomment-89093322
  
    @saucam, thanks for working on this and sorry for the delay due to the 1.3 release.  I think the best option here is to use statistics and only collect when we know the size is going to be pretty small.  It would also be good to reconcile it with the other options for handling exist queries when the statistics suggest the other table is large.  Finally, we'll need a bunch of tests for this new feature.  Until you have time to update, I suggest we close this issue to keep the PR queue small and manageable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org