You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2016/05/23 11:26:46 UTC

svn commit: r1745142 - in /tomcat/trunk/test/org/apache/coyote/http2: Http2TestBase.java TestHttp2Section_5_3.java TestHttp2Section_6_3.java TestHttp2Section_6_4.java TestHttp2Section_6_9.java

Author: markt
Date: Mon May 23 11:26:46 2016
New Revision: 1745142

URL: http://svn.apache.org/viewvc?rev=1745142&view=rev
Log:
Add missing new line from end of reset log message.
Reset isn't always the last frame to be traced and this makes it easier to read.

Modified:
    tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java
    tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java
    tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java
    tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java
    tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_9.java

Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java?rev=1745142&r1=1745141&r2=1745142&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java (original)
+++ tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java Mon May 23 11:26:46 2016
@@ -803,7 +803,7 @@ public abstract class Http2TestBase exte
 
         @Override
         public void reset(int streamId, long errorCode) {
-            trace.append(streamId + "-RST-[" + errorCode + "]");
+            trace.append(streamId + "-RST-[" + errorCode + "]\n");
         }
 
 

Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java?rev=1745142&r1=1745141&r2=1745142&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java (original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java Mon May 23 11:26:46 2016
@@ -44,7 +44,7 @@ public class TestHttp2Section_5_3 extend
 
         parser.readFrame(true);
 
-        Assert.assertEquals("3-RST-[1]",  output.getTrace());
+        Assert.assertEquals("3-RST-[1]\n",  output.getTrace());
     }
 
 

Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java?rev=1745142&r1=1745141&r2=1745142&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java (original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java Mon May 23 11:26:46 2016
@@ -88,7 +88,7 @@ public class TestHttp2Section_6_3 extend
         // Read GOAWAY frame
         parser.readFrame(true);
 
-        Assert.assertEquals("3-RST-[" + Http2Error.FRAME_SIZE_ERROR.getCode() + "]",
+        Assert.assertEquals("3-RST-[" + Http2Error.FRAME_SIZE_ERROR.getCode() + "]\n",
                 output.getTrace());
     }
 }

Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java?rev=1745142&r1=1745141&r2=1745142&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java (original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java Mon May 23 11:26:46 2016
@@ -81,7 +81,7 @@ public class TestHttp2Section_6_4 extend
         // Read GOAWAY frame
         parser.readFrame(true);
 
-        Assert.assertEquals("3-RST-[" + Http2Error.FRAME_SIZE_ERROR.getCode() + "]",
+        Assert.assertEquals("3-RST-[" + Http2Error.FRAME_SIZE_ERROR.getCode() + "]\n",
                 output.getTrace());
     }
 }

Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_9.java?rev=1745142&r1=1745141&r2=1745142&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_9.java (original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_9.java Mon May 23 11:26:46 2016
@@ -52,7 +52,7 @@ public class TestHttp2Section_6_9 extend
 
         parser.readFrame(true);
 
-        Assert.assertEquals("3-RST-[" + Http2Error.PROTOCOL_ERROR.getCode() + "]",
+        Assert.assertEquals("3-RST-[" + Http2Error.PROTOCOL_ERROR.getCode() + "]\n",
                 output.getTrace());
     }
 
@@ -138,7 +138,7 @@ public class TestHttp2Section_6_9 extend
 
         parser.readFrame(true);
 
-        Assert.assertEquals("3-RST-[" + Http2Error.FLOW_CONTROL_ERROR.getCode() + "]",
+        Assert.assertEquals("3-RST-[" + Http2Error.FLOW_CONTROL_ERROR.getCode() + "]\n",
                 output.getTrace());
     }
 
@@ -283,7 +283,7 @@ public class TestHttp2Section_6_9 extend
         sendSettings(0, false, new SettingValue(4,  1 << 30));
         // Ack
         parser.readFrame(true);
-        Assert.assertEquals("3-RST-[" + Http2Error.FLOW_CONTROL_ERROR.getCode() + "]",
+        Assert.assertEquals("3-RST-[" + Http2Error.FLOW_CONTROL_ERROR.getCode() + "]\n",
                 output.getTrace());
 
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org