You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Mark Chu-Carroll <mc...@twitter.com> on 2013/12/20 14:38:05 UTC
Review Request 16423: client v2: added implementations of job diff,
job inspect.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/
-----------------------------------------------------------
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Repository: aurora
Description
-------
Implemented client v2 versions of the diff and inspect verbs.
Diffs
-----
src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
src/main/python/twitter/aurora/client/cli/BUILD 0a44a218d170a8e6874911befddc0daf744c433e
src/main/python/twitter/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
src/main/python/twitter/aurora/client/cli/jobs.py e66f1811b14a469a8c232887dd21fcc09dfa4b84
src/main/python/twitter/aurora/client/cli/options.py 64a58f8b3e198bb770550c854347220975e74312
src/main/python/twitter/aurora/client/options.py 7ced9611c2aec6fec601f1ff61ce4defed3d977f
src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
Diff: https://reviews.apache.org/r/16423/diff/
Testing
-------
Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
Thanks,
Mark Chu-Carroll
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31401
-----------------------------------------------------------
ping?
- Mark Chu-Carroll
On Dec. 20, 2013, 8:38 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2013, 8:38 a.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD 0a44a218d170a8e6874911befddc0daf744c433e
> src/main/python/twitter/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py e66f1811b14a469a8c232887dd21fcc09dfa4b84
> src/main/python/twitter/aurora/client/cli/options.py 64a58f8b3e198bb770550c854347220975e74312
> src/main/python/twitter/aurora/client/options.py 7ced9611c2aec6fec601f1ff61ce4defed3d977f
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31615
-----------------------------------------------------------
Sorry about the merge glitches; that was sloppy of me. I shouldn't have tried to push the branch-merge so quickly.
src/test/python/twitter/aurora/client/cli/BUILD
<https://reviews.apache.org/r/16423/#comment60210>
Weird - don't see this in my workspace. Strange; I must have done something stupid like not saved one of my open buffers before pushing the review.
- Mark Chu-Carroll
On Jan. 8, 2014, 7:12 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 7:12 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Jonathan Boulle <jo...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31678
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60381>
[] is superfluous fwiw
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment60382>
s/ommit/omit/
src/test/python/apache/aurora/client/cli/test_status.py
<https://reviews.apache.org/r/16423/#comment60383>
?
- Jonathan Boulle
On Jan. 13, 2014, 10:28 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 10:28 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 5:28 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Addressed latest round of reviews.
Repository: aurora
Description
-------
Implemented client v2 versions of the diff and inspect verbs.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
Diff: https://reviews.apache.org/r/16423/diff/
Testing
-------
Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
Thanks,
Mark Chu-Carroll
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31620
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60243>
this can be 'for component in key' since namedtuples and AuroraJobKeys are iterable.
- Brian Wickman
On Jan. 13, 2014, 3:02 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 3:02 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Jonathan Boulle <jo...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31650
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/16423/#comment60331>
kill
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60334>
s/file/file./
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60332>
%s/job_key/jobkey/g
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60333>
result.extend(...)
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60335>
kill
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60336>
return resp.... or []
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment60341>
no help()?
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment60340>
no help()?
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment60339>
could this just live on the class?
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment60338>
s/specifying/setting/
src/test/python/apache/aurora/client/cli/util.py
<https://reviews.apache.org/r/16423/#comment60344>
hm, remove?
src/test/python/twitter/aurora/client/cli/BUILD
<https://reviews.apache.org/r/16423/#comment60342>
:/
src/test/python/twitter/aurora/client/cli/test_diff.py
<https://reviews.apache.org/r/16423/#comment60343>
nit: could we use a more generic username for all the tests?
- Jonathan Boulle
On Jan. 13, 2014, 3:02 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 3:02 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31663
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment60351>
Could, but then it would get created even when users aren't running diff.
- Mark Chu-Carroll
On Jan. 13, 2014, 10:02 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 10:02 a.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 10:02 a.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
More review fixes: in particular, fix up messed up merge.
Repository: aurora
Description
-------
Implemented client v2 versions of the diff and inspect verbs.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
Diff: https://reviews.apache.org/r/16423/diff/
Testing
-------
Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
Thanks,
Mark Chu-Carroll
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31414
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59883>
from apache
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59886>
revert?
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59887>
revert?
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59885>
revert?
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59884>
revert?
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59888>
join() accepts a generator so [] can be removed. nbd.
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59889>
i think AuroraJobKeys have an __iter__ method so you can unwrap this if you want:
cluster, role, env, name = context.options.rename_from
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59890>
if result not in (0, 1):
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59891>
ultra-minor nit -- if we ever add more constraints other than order= to Constraint, this could break, so you _may_ want to say 'constant.order() or []'
src/test/python/twitter/aurora/client/cli/BUILD
<https://reviews.apache.org/r/16423/#comment59892>
missed merge
- Brian Wickman
On Jan. 9, 2014, 12:12 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 12:12 a.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 7:12 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Rebased this diff against the status command branch.
Repository: aurora
Description
-------
Implemented client v2 versions of the diff and inspect verbs.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627
src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
Diff: https://reviews.apache.org/r/16423/diff/
Testing
-------
Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
Thanks,
Mark Chu-Carroll
Re: Review Request 16423: client v2: added implementations of job diff,
job inspect.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31409
-----------------------------------------------------------
can this diff be generated off the branch with status/create? that way we just see what needs to be reviewed.
- Brian Wickman
On Dec. 20, 2013, 1:38 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2013, 1:38 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented client v2 versions of the diff and inspect verbs.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD 0a44a218d170a8e6874911befddc0daf744c433e
> src/main/python/twitter/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py e66f1811b14a469a8c232887dd21fcc09dfa4b84
> src/main/python/twitter/aurora/client/cli/options.py 64a58f8b3e198bb770550c854347220975e74312
> src/main/python/twitter/aurora/client/options.py 7ced9611c2aec6fec601f1ff61ce4defed3d977f
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16423/diff/
>
>
> Testing
> -------
>
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already tested.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>