[GitHub] [tvm] jroesch commented on a change in pull request #8309: [Relay] Remove in-place modification of attributes in layout transform

[GitBox <gi...@apache.org>]

jroesch commented on a change in pull request #8309:
URL: https://github.com/apache/tvm/pull/8309#discussion_r658272825



##########
File path: src/relay/transforms/infer_layout_utils.h
##########
@@ -85,6 +85,30 @@ inline Layout AdjustSubordinateFactors(const Layout& src_layout, const Layout& o
   return Layout(new_layout);
 }
 
+/*
+ * \brief An output structure to hold results from FInferCorrectLayout calls.
+ * \tparam inferred_layout An array of two elements, inferred input layouts and
+ *                         inferred output layouts.
+ * \tparam new_attrs Updated attributes consistent with inferred layouts
+ */
+class InferCorrectLayoutOutputNode : public Object {
+ public:
+  Array<Array<Layout>> inferred_layout;

Review comment:
       Can we change the inner thing to actually be a data structure instead of using Array's to represent structures/pairs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org