You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/08 13:03:00 UTC

[GitHub] [shardingsphere] isHuangXin opened a new pull request, #18967: update the export-distsql print format

isHuangXin opened a new pull request, #18967:
URL: https://github.com/apache/shardingsphere/pull/18967

   Modify the export-distsql print format
   
   - Before modify the print format
   ![image](https://user-images.githubusercontent.com/57054352/177996871-06349593-bb39-4fb1-8c77-27e869cca546.png)
   
   - Before modify the print format
   ![image](https://user-images.githubusercontent.com/57054352/177996886-98e2e85e-f51a-4d71-80e7-0b0158bbd59c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] isHuangXin commented on pull request #18967: update the export-distsql print format

Posted by GitBox <gi...@apache.org>.
isHuangXin commented on PR #18967:
URL: https://github.com/apache/shardingsphere/pull/18967#issuecomment-1179503207

   I'm a beginner of open source projects, this PR is just to verify that I can submit a PR to shardingsphere correctly.
   
   I am developing a new distsql statement `convert distsql`, which can automatically parse yaml files and generate distsql statements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] isHuangXin closed pull request #18967: update the export-distsql print format

Posted by GitBox <gi...@apache.org>.
isHuangXin closed pull request #18967: update the export-distsql print format
URL: https://github.com/apache/shardingsphere/pull/18967


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #18967: update the export-distsql print format

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18967:
URL: https://github.com/apache/shardingsphere/pull/18967#issuecomment-1179986383

   The CI still break, please fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] isHuangXin commented on pull request #18967: update the export-distsql print format

Posted by GitBox <gi...@apache.org>.
isHuangXin commented on PR #18967:
URL: https://github.com/apache/shardingsphere/pull/18967#issuecomment-1179502572

   > Could you fix CI?
   I think this error may be affecting import distsql when undating export distsql. 
   I re-updated the code. plz check it~ thx.
   
   - Before this time update
   ![image](https://user-images.githubusercontent.com/57054352/178097835-95785cb8-9f84-4e9d-9942-f1ae9188a1df.png)
   
   - After this time update
   ![image](https://user-images.githubusercontent.com/57054352/178097843-8a9097df-7d4c-471b-8cf3-7a00ad922660.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #18967: update the export-distsql print format

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18967:
URL: https://github.com/apache/shardingsphere/pull/18967#issuecomment-1179978285

   > I'm a beginner of open source projects, this PR is just to verify that I can submit a PR to shardingsphere correctly.
   > 
   > I am developing a new distsql statement `convert distsql`, which can automatically parse yaml files and generate distsql statements.
   
   Great!, Welcome to join the community and develop more and more interesting features. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] isHuangXin commented on pull request #18967: update the export-distsql print format

Posted by GitBox <gi...@apache.org>.
isHuangXin commented on PR #18967:
URL: https://github.com/apache/shardingsphere/pull/18967#issuecomment-1181532022

   > The CI still break, please fix it.
   
   Please review again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org