You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by rb...@covalent.net on 2000/04/14 18:56:33 UTC
apr_config.h is a private header...
I was digging in some code today, and I noticed that prefork.c is
including apr_config.h, which opens a bunch of autoconf macros which are
not namespace protected.
I'll be fixing this, but I am wondering what people would think of
renaming apr_config.h to apr_private.h. This should re-inforce the idea
that apr_config.h should never be included outside of private APR C files,
because it is not fully namespace protected.
Thoughts?
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: apr_config.h is a private header...
Posted by Greg Stein <gs...@lyra.org>.
On Fri, 14 Apr 2000, Manoj Kasichainula wrote:
> On Fri, Apr 14, 2000 at 02:04:45PM -0400, rbb@covalent.net wrote:
> > We actually used to have a separate directory for private header files in
> > APR. The fact is that with APR, there is only one private header file and
> > it shouldn't be copied over in the install procedure. Moving that one
> > file to its own directory just causes the Makefiles to get bigger because
> > we have to add an include directive for every Makefile. I ended up
> > disliking this setup when I had it that way originally.
>
> It just doesn't feel right to have private and public include files in
> the same directories, since they server totally different purposes.
> *shrug*
This is where pragmatism wins out over idealism :-)
I'll also take a comment from the Python world:
"We're all adults here."
In other words: It's private. Respect that. Don't include it.
:-)
--
Greg Stein, http://www.lyra.org/
Re: apr_config.h is a private header...
Posted by Manoj Kasichainula <ma...@io.com>.
On Fri, Apr 14, 2000 at 02:04:45PM -0400, rbb@covalent.net wrote:
> We actually used to have a separate directory for private header files in
> APR. The fact is that with APR, there is only one private header file and
> it shouldn't be copied over in the install procedure. Moving that one
> file to its own directory just causes the Makefiles to get bigger because
> we have to add an include directive for every Makefile. I ended up
> disliking this setup when I had it that way originally.
It just doesn't feel right to have private and public include files in
the same directories, since they server totally different purposes.
*shrug*
RE: apr_config.h is a private header...
Posted by "William A. Rowe, Jr." <wr...@lnd.com>.
Q. Is is possible to create a /src/lib/apr/include/internal path and
#include "internal/ap_config.h" which makes the intent -very- clear.
No extra include directories to search, and the makefile should not
become significantly larger. I don't know if this is sufficiently
portable (obviously, <sys/something> is supported, but "sys/something"?)
> -----Original Message-----
> From: rbb@covalent.net [mailto:rbb@covalent.net]
> Sent: Friday, April 14, 2000 1:05 PM
> To: new-httpd@apache.org
> Subject: Re: apr_config.h is a private header...
>
>
> On Fri, 14 Apr 2000, Manoj Kasichainula wrote:
>
> > On Fri, Apr 14, 2000 at 12:56:33PM -0400, rbb@covalent.net wrote:
> > > I'll be fixing this, but I am wondering what people would think of
> > > renaming apr_config.h to apr_private.h. This should
> re-inforce the idea
> > > that apr_config.h should never be included outside of
> private APR C files,
> > > because it is not fully namespace protected.
> >
> > It'd be better to move private include files out of the include
> > directory. I'd like to do this with Apache as well.
>
> We actually used to have a separate directory for private
> header files in
> APR. The fact is that with APR, there is only one private
> header file and
> it shouldn't be copied over in the install procedure. Moving that one
> file to its own directory just causes the Makefiles to get
> bigger because
> we have to add an include directive for every Makefile. I ended up
> disliking this setup when I had it that way originally.
>
> Although it probably makes sense for Apache, where there are multiple
> private headers.
>
> Ryan
>
> ______________________________________________________________
> _________________
> Ryan Bloom rbb@apache.org
> 406 29th St.
> San Francisco, CA 94131
> --------------------------------------------------------------
> -----------------
>
Re: apr_config.h is a private header...
Posted by rb...@covalent.net.
On Fri, 14 Apr 2000, Manoj Kasichainula wrote:
> On Fri, Apr 14, 2000 at 12:56:33PM -0400, rbb@covalent.net wrote:
> > I'll be fixing this, but I am wondering what people would think of
> > renaming apr_config.h to apr_private.h. This should re-inforce the idea
> > that apr_config.h should never be included outside of private APR C files,
> > because it is not fully namespace protected.
>
> It'd be better to move private include files out of the include
> directory. I'd like to do this with Apache as well.
We actually used to have a separate directory for private header files in
APR. The fact is that with APR, there is only one private header file and
it shouldn't be copied over in the install procedure. Moving that one
file to its own directory just causes the Makefiles to get bigger because
we have to add an include directive for every Makefile. I ended up
disliking this setup when I had it that way originally.
Although it probably makes sense for Apache, where there are multiple
private headers.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: apr_config.h is a private header...
Posted by Manoj Kasichainula <ma...@io.com>.
On Fri, Apr 14, 2000 at 12:56:33PM -0400, rbb@covalent.net wrote:
> I'll be fixing this, but I am wondering what people would think of
> renaming apr_config.h to apr_private.h. This should re-inforce the idea
> that apr_config.h should never be included outside of private APR C files,
> because it is not fully namespace protected.
It'd be better to move private include files out of the include
directory. I'd like to do this with Apache as well.
Re: apr_config.h is a private header...
Posted by Greg Stein <gs...@lyra.org>.
On Fri, 14 Apr 2000 rbb@covalent.net wrote:
> I'll be fixing this, but I am wondering what people would think of
> renaming apr_config.h to apr_private.h. This should re-inforce the idea
> that apr_config.h should never be included outside of private APR C files,
> because it is not fully namespace protected.
+1
--
Greg Stein, http://www.lyra.org/