[ https://issues.apache.org/jira/browse/OPENNLP-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028386#comment-16028386 ]
ASF GitHub Bot commented on OPENNLP-1081:
-----------------------------------------
GitHub user thygesen opened a pull request:
https://github.com/apache/opennlp/pull/220
OPENNLP-1081: Fix Dictionary support to GeneratorFactory::extractArtifactSerializerMappings
Added Dictionary support "again"... (I think).
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [√] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [√] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [√] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [√] Is your initial contribution a single, squashed commit?
### For code changes:
- [√] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [√] Have you written or updated unit tests to verify your changes?
- [√] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [na] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [na] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thygesen/opennlp opennlp-1081
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #220
----
commit c5bf0ec97e27f7d8e8cd7363ada554f64ab976ec
Author: thygesen <th...@apache.org>
Date: 2017-05-29T14:07:35Z
OPENNLP-1081: Fix Dictionary support to GeneratorFactory::extractArtifactSerializerMappings
----
> Fix Dictionary support to GeneratorFactory::extractArtifactSerializerMappings
> -----------------------------------------------------------------------------
>
> Key: OPENNLP-1081
> URL: https://issues.apache.org/jira/browse/OPENNLP-1081
> Project: OpenNLP
> Issue Type: Bug
> Components: Name Finder
> Affects Versions: 1.8.0
> Reporter: Peter Thygesen
> Assignee: Peter Thygesen
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GeneratorFactory.extractArtifactSerializerMappings does not support Dictionaries.
> E.g.
> feature.xml
> <generators>
> <cache>
> <generators>
> ...
> <dictionary dict="locations.dict"/>
> </generators>
> </cache>
> </generators>
> running opennlp TokenNameFinderTrainer.brat
> -resources /my/resources
> -featuregen feature.xml
> results in:
> FeatureGeneratorCreationError: opennlp.tools.util.InvalidFormatException: No dictionary resource for key: locations.dict
> Even though the file is present in the resources folder.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)