You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by wu-sheng <gi...@git.apache.org> on 2017/01/11 11:44:15 UTC

[GitHub] incubator-rocketmq pull request #3: [ROCKETMQ-6] Use logger for exceptions i...

Github user wu-sheng commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/3#discussion_r95562388
  
    --- Diff: broker/src/main/java/org/apache/rocketmq/broker/processor/PullMessageProcessor.java ---
    @@ -87,8 +87,8 @@ private RemotingCommand processRequest(final Channel channel, RemotingCommand re
     
             response.setOpaque(request.getOpaque());
     
    -        if (LOG.isDebugEnabled()) {
    -            LOG.debug("receive PullMessage request command, {}", request);
    +        if (log.isDebugEnabled()) {
    --- End diff --
    
    `log.isDebugEnabled()` is not necessary, and do not consistent with other codes log-style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---