You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/06/09 13:42:54 UTC

[GitHub] [arrow] mapleFU commented on pull request #35825: GH-32723: [C++][Parquet] Add option to use LARGE* variants of binary types

mapleFU commented on PR #35825:
URL: https://github.com/apache/arrow/pull/35825#issuecomment-1584600149

   Well hold on, I guess I misunderstand some piece of the code. Seems that this patch has two parts:
   1. If set `use_large_binary_variants`, arrow reader for that field should have internal type `LargeBinaryArray` or `LargeStringArray`
   2. If set `use_large_binary_variants`, using `LargeBinary` or `LargeBinaryArray` to build the accumulator
   
   Seems that `store_schema` only ensures "1"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org