[GitHub] [incubator-tvm] masahi commented on a change in pull request #6546: Feat(frontend-pytorch): Add input types argument and Support cast to …

[GitBox <gi...@apache.org>]

masahi commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-tvm/pull/6546#discussion_r494117103



##########
File path: python/tvm/relay/frontend/pytorch.py
##########
@@ -3244,7 +3267,8 @@ def get_all_op_names(graph):
     return set(node.kind() for node in nodes)
 
 
-def from_pytorch(script_module, input_shapes, custom_convert_map=None, default_dtype="float32"):
+def from_pytorch(script_module, input_shapes, custom_convert_map=None, default_dtype="float32",
+                 input_types=None):

Review comment:
       yeah, I also prefer stuffing types into the tuple (name, (shape, type)) and rename input_shapes to something like input_info or something




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org