You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Roth <ma...@sun.com> on 2002/08/24 07:42:09 UTC

[PATCH] jakarta-tomcat-jasper: PFD features and bugfixes 5

Attached is a fifth and final (from me) patch to move us towards JSP 2.0
PFD feature-complete.  Back to the spec for me :)

Files Changed (IN PATCH)
-------------
jasper2/src/share/org/apache/jasper/compiler/Generator.java
jasper2/src/share/org/apache/jasper/compiler/JspConfig.java
jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
jasper2/src/share/org/apache/jasper/compiler/JspReader.java
jasper2/src/share/org/apache/jasper/compiler/Node.java
jasper2/src/share/org/apache/jasper/compiler/Parser.java
jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
jasper2/src/share/org/apache/jasper/compiler/Validator.java
jasper2/src/share/org/apache/jasper/resources/messages.properties


Summary of changes:
    - Updated taglib namespace support in XML parser to support xmlns:
      attributes on any node.  Redefinitions are still disallowed, and
      scoping is not implemented.  The spec needs some clarification 
      in this space before we do more, but this will give users an
      opportunity to experiment and provide feedback.
    - Now fully supports multiple <url-pattern> elements 
      per <jsp-property-group>.
    - Implemented the following attributes for the tag directive (they
      were parsed but effectively NOPs before):
        - language
        - isScriptingEnabled
        - isELEnabled
        - pageEncoding
        - import
    - Implemented support for XML elements in standard syntax, as per
      the PFD specification.  The following elements can now be used
      in standard syntax JSP pages:
        - jsp:scriptlet
        - jsp:expression
        - jsp:declaration
	- jsp:text
        - jsp:directive.page
        - jsp:directive.include

      and in tag files...
        - jsp:scriptlet
        - jsp:expression
        - jsp:declaration
	- jsp:text
        - jsp:directive.include
        - jsp:directive.tag
        - jsp:directive.variable
        - jsp:directive.attribute
    - Fixed NPE in tag file generation: When no value was passed for
      an attribute, a NPE was being thrown.  Now checks if attribute is
      null before assigning a page-scoped variable.


As usual, please let me know if there are any questions or concerns.

--
Mark Roth, Java Software
JSP 2.0 Specification Co-Lead
Sun Microsystems, Inc.


Re: [PATCH] jakarta-tomcat-jasper: PFD features and bugfixes 5

Posted by Mark Roth <ma...@sun.com>.
Thanks for applying the patch, Justy!

The changes to resources/messages.properties are in the patch - it's the
last file.  I did not see it in your commit, however.

Can you please double-check that you've committed all files changed by
the patch?  

Thanks,
- Mark

On Sat, 2002-08-24 at 17:48, Justyna Horwat wrote:
> I applied this patch.
> 
> However, in your changed files you mention a resources file but it's 
> missing from your attachment. If the resources file has changed can you 
> submit it? Did you say "final"  :)
> 
> Thanks,
> 
> Justy
> 
> Mark Roth wrote:
> 
> >Attached is a fifth and final (from me) patch to move us towards JSP 2.0
> >PFD feature-complete.  Back to the spec for me :)
> >
> >Files Changed (IN PATCH)
> >-------------
> >jasper2/src/share/org/apache/jasper/compiler/Generator.java
> >jasper2/src/share/org/apache/jasper/compiler/JspConfig.java
> >jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
> >jasper2/src/share/org/apache/jasper/compiler/JspReader.java
> >jasper2/src/share/org/apache/jasper/compiler/Node.java
> >jasper2/src/share/org/apache/jasper/compiler/Parser.java
> >jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
> >jasper2/src/share/org/apache/jasper/compiler/Validator.java
> >jasper2/src/share/org/apache/jasper/resources/messages.properties
> >
> >
> >Summary of changes:
> >    - Updated taglib namespace support in XML parser to support xmlns:
> >      attributes on any node.  Redefinitions are still disallowed, and
> >      scoping is not implemented.  The spec needs some clarification 
> >      in this space before we do more, but this will give users an
> >      opportunity to experiment and provide feedback.
> >    - Now fully supports multiple <url-pattern> elements 
> >      per <jsp-property-group>.
> >    - Implemented the following attributes for the tag directive (they
> >      were parsed but effectively NOPs before):
> >        - language
> >        - isScriptingEnabled
> >        - isELEnabled
> >        - pageEncoding
> >        - import
> >    - Implemented support for XML elements in standard syntax, as per
> >      the PFD specification.  The following elements can now be used
> >      in standard syntax JSP pages:
> >        - jsp:scriptlet
> >        - jsp:expression
> >        - jsp:declaration
> >	- jsp:text
> >        - jsp:directive.page
> >        - jsp:directive.include
> >
> >      and in tag files...
> >        - jsp:scriptlet
> >        - jsp:expression
> >        - jsp:declaration
> >	- jsp:text
> >        - jsp:directive.include
> >        - jsp:directive.tag
> >        - jsp:directive.variable
> >        - jsp:directive.attribute
> >    - Fixed NPE in tag file generation: When no value was passed for
> >      an attribute, a NPE was being thrown.  Now checks if attribute is
> >      null before assigning a page-scoped variable.
> >
> >
> >As usual, please let me know if there are any questions or concerns.
> >
> >--
> >Mark Roth, Java Software
> >JSP 2.0 Specification Co-Lead
> >Sun Microsystems, Inc.
> >
> 
> 



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] jakarta-tomcat-jasper: PFD features and bugfixes 5

Posted by Justyna Horwat <Ju...@Sun.com>.
I applied this patch.

However, in your changed files you mention a resources file but it's 
missing from your attachment. If the resources file has changed can you 
submit it? Did you say "final"  :)

Thanks,

Justy

Mark Roth wrote:

>Attached is a fifth and final (from me) patch to move us towards JSP 2.0
>PFD feature-complete.  Back to the spec for me :)
>
>Files Changed (IN PATCH)
>-------------
>jasper2/src/share/org/apache/jasper/compiler/Generator.java
>jasper2/src/share/org/apache/jasper/compiler/JspConfig.java
>jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
>jasper2/src/share/org/apache/jasper/compiler/JspReader.java
>jasper2/src/share/org/apache/jasper/compiler/Node.java
>jasper2/src/share/org/apache/jasper/compiler/Parser.java
>jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
>jasper2/src/share/org/apache/jasper/compiler/Validator.java
>jasper2/src/share/org/apache/jasper/resources/messages.properties
>
>
>Summary of changes:
>    - Updated taglib namespace support in XML parser to support xmlns:
>      attributes on any node.  Redefinitions are still disallowed, and
>      scoping is not implemented.  The spec needs some clarification 
>      in this space before we do more, but this will give users an
>      opportunity to experiment and provide feedback.
>    - Now fully supports multiple <url-pattern> elements 
>      per <jsp-property-group>.
>    - Implemented the following attributes for the tag directive (they
>      were parsed but effectively NOPs before):
>        - language
>        - isScriptingEnabled
>        - isELEnabled
>        - pageEncoding
>        - import
>    - Implemented support for XML elements in standard syntax, as per
>      the PFD specification.  The following elements can now be used
>      in standard syntax JSP pages:
>        - jsp:scriptlet
>        - jsp:expression
>        - jsp:declaration
>	- jsp:text
>        - jsp:directive.page
>        - jsp:directive.include
>
>      and in tag files...
>        - jsp:scriptlet
>        - jsp:expression
>        - jsp:declaration
>	- jsp:text
>        - jsp:directive.include
>        - jsp:directive.tag
>        - jsp:directive.variable
>        - jsp:directive.attribute
>    - Fixed NPE in tag file generation: When no value was passed for
>      an attribute, a NPE was being thrown.  Now checks if attribute is
>      null before assigning a page-scoped variable.
>
>
>As usual, please let me know if there are any questions or concerns.
>
>--
>Mark Roth, Java Software
>JSP 2.0 Specification Co-Lead
>Sun Microsystems, Inc.
>



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>