You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/12/08 21:27:16 UTC

[GitHub] [httpcomponents-core] robtimus commented on pull request #236: Add filters before MAIN_HANDLER so they won't be ignored

robtimus commented on pull request #236:
URL: https://github.com/apache/httpcomponents-core/pull/236#issuecomment-741059236


   @carterkozak: I added three new test classes:
   * `ClassicServerBootstrapFilterTest`
   * `AsyncServerBootstrapFilterTest`
   * `H2ServerBootstrapFiltersTest`
   
   I based these on `ClassicServerAndRequesterTest`, `Http1ServerAndRequesterTest` and `H2ServerAndRequesterTest` respectively, but stripped out most of the non-essential stuff. These fail because the `X-Test-Filter` header cannot be found when executed against master, and succeed when executed against these changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org