You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/02 04:21:24 UTC

[GitHub] [skywalking-java] lujiajing1126 commented on a diff in pull request #166: [Polish] Code level polish (no logic change)

lujiajing1126 commented on code in PR #166:
URL: https://github.com/apache/skywalking-java/pull/166#discussion_r862581072


##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/util/CustomizeExpression.java:
##########
@@ -37,7 +37,7 @@ public class CustomizeExpression {
     private static final ILog LOGGER = LogManager.getLogger(CustomizeExpression.class);
 
     public static Map<String, Object> evaluationContext(Object[] allArguments) {
-        Map<String, Object> context = new HashMap<>();
+        Map<String, Object> context = new HashMap<>(allArguments.length, 1);

Review Comment:
   If you think the load factor is critical, you may provide the report of microbenchmarks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org