[GitHub] [incubator-pinot] npawar commented on a change in pull request #4790: Support ORDER BY for DISTINCT queries

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #4790: Support ORDER BY for DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342835413
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/SimpleIndexedTable.java
 ##########
 @@ -139,6 +144,14 @@ public int size() {
 
   @Override
   public Iterator<Record> iterator() {
+    if (_iterator == null) {
 
 Review comment:
   if you do this, you allow the  possibility that the _lookupMap gets modified while you are iterating

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org