You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/19 18:07:38 UTC
[GitHub] [cloudstack] andrijapanicsb opened a new pull request #3822: set
TCP as default protocol in lb list
andrijapanicsb opened a new pull request #3822: set TCP as default protocol in lb list
URL: https://github.com/apache/cloudstack/pull/3822
## Description
Instead of "SSL" being set as a default LB protocol when configuring a LB rule, set TCP as the default one - move SSL to the bottom of the list.
Reason: SSL is supported only with NetScaller and should not even be there if VPC is not using NetScaller for LB services... so stop offering it as the default protocol and confusing VPC VR (i.e. non-NesScaller users)
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
Old setup:
New setup:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3822: set TCP as
default protocol in lb list
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3822: set TCP as default protocol in lb list
URL: https://github.com/apache/cloudstack/pull/3822#issuecomment-576030366
Can be tested by downloading the patch file to mgmt server https://github.com/apache/cloudstack/commit/b9f39757506e0831ebcf015c408f6e93f7198c0d.patch
and applying a patch:
cd /usr/share/cloudstack-management/webapp/scripts
patch < b9f39757506e0831ebcf015c408f6e93f7198c0d.patch
refresh the gui with ctrl +alt + R
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3822: set TCP as
default protocol in lb list
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3822: set TCP as default protocol in lb list
URL: https://github.com/apache/cloudstack/pull/3822#issuecomment-576297431
@andrijapanicsb not for 4.13? (lgtm otherwise)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb merged pull request #3822: set TCP as
default protocol in lb list
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #3822: set TCP as default protocol in lb list
URL: https://github.com/apache/cloudstack/pull/3822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3822: set TCP as
default protocol in lb list
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3822: set TCP as default protocol in lb list
URL: https://github.com/apache/cloudstack/pull/3822#issuecomment-576322547
not in 4.13 as its not a bug fix @dahn.
Merging based on 2 LGTMs and manual testing. Automated testing not needed as this is a simple JS change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services