You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2019/11/23 00:51:11 UTC

[Impala-ASF-CR] IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14791


Change subject: IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."
......................................................................

IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

This reverts commit 0c0671e04e9a71ebcba0e64d28b15f5c332f35ff.

Conflicts:
	fe/src/main/java/org/apache/impala/catalog/Table.java

Change-Id: I28d9801493cfeb6a4513040fd0557fc684975249
---
M be/src/rpc/kerberos-test.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M bin/rat_exclude_files.txt
M common/thrift/Frontend.thrift
M common/thrift/hive-1-api/TCLIService.thrift
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/catalog/FeTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/MetadataOp.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/common/FrontendFixture.java
M fe/src/test/java/org/apache/impala/service/JdbcTest.java
M testdata/data/README
D testdata/data/child_table.txt
D testdata/data/parent_table.txt
D testdata/data/parent_table_2.txt
M testdata/datasets/functional/functional_schema_template.sql
M tests/hs2/test_hs2.py
25 files changed, 48 insertions(+), 835 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14791/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28d9801493cfeb6a4513040fd0557fc684975249
Gerrit-Change-Number: 14791
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14791 )

Change subject: IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."
......................................................................


Patch Set 1:

Still testing this on a build with USE_CDP_HIVE=true, in the mean time trying to figure out if there is an easy figure for the issue so we can avoid the revert.


-- 
To view, visit http://gerrit.cloudera.org:8080/14791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28d9801493cfeb6a4513040fd0557fc684975249
Gerrit-Change-Number: 14791
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Nov 2019 01:40:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has abandoned this change. ( http://gerrit.cloudera.org:8080/14791 )

Change subject: IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/14791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I28d9801493cfeb6a4513040fd0557fc684975249
Gerrit-Change-Number: 14791
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14791 )

Change subject: IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5126/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28d9801493cfeb6a4513040fd0557fc684975249
Gerrit-Change-Number: 14791
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Nov 2019 01:35:05 +0000
Gerrit-HasComments: No