You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/28 13:27:14 UTC
[GitHub] [shardingsphere] juaby opened a new pull request #7135: Replica features
juaby opened a new pull request #7135:
URL: https://github.com/apache/shardingsphere/pull/7135
Changes proposed in this pull request:
- Support multi replica extension
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7135: Replica features
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7135:
URL: https://github.com/apache/shardingsphere/pull/7135#issuecomment-682592919
## Pull Request Test Coverage Report for [Build 14228](https://coveralls.io/builds/33073638)
* **144** of **307** **(46.91%)** changed or added relevant lines in **39** files are covered.
* **3** unchanged lines in **3** files lost coverage.
* Overall coverage increased (+**0.007%**) to **35.556%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-replica/shardingsphere-replica-common/src/main/java/org/apache/shardingsphere/replica/yaml/config/YamlReplicaRuleConfiguration.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-features%2Fshardingsphere-replica%2Fshardingsphere-replica-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Freplica%2Fyaml%2Fconfig%2FYamlReplicaRuleConfiguration.java#L43) | 4 | 5 | 80.0%
| [shardingsphere-infra/shardingsphere-infra-executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/group/AbstractExecuteGroupEngine.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-infra%2Fshardingsphere-infra-executor%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fexecutor%2Fsql%2Fgroup%2FAbstractExecuteGroupEngine.java#L83) | 2 | 3 | 66.67%
| [shardingsphere-infra/shardingsphere-infra-executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/raw/group/RawExecuteGroupEngine.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-infra%2Fshardingsphere-infra-executor%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fexecutor%2Fsql%2Fraw%2Fgroup%2FRawExecuteGroupEngine.java#L42) | 0 | 1 | 0.0%
| [shardingsphere-infra/shardingsphere-infra-route/src/main/java/org/apache/shardingsphere/infra/route/DataNodeRouter.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-infra%2Fshardingsphere-infra-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Froute%2FDataNodeRouter.java#L105) | 3 | 4 | 75.0%
| [shardingsphere-features/shardingsphere-replica/shardingsphere-replica-common/src/main/java/org/apache/shardingsphere/replica/rule/ReplicaRule.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-features%2Fshardingsphere-replica%2Fshardingsphere-replica-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Freplica%2Frule%2FReplicaRule.java#L54) | 17 | 19 | 89.47%
| [shardingsphere-infra/shardingsphere-infra-executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/context/ExecutionContext.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-infra%2Fshardingsphere-infra-executor%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fexecutor%2Fsql%2Fcontext%2FExecutionContext.java#L43) | 5 | 7 | 71.43%
| [shardingsphere-infra/shardingsphere-infra-rewrite/shardingsphere-infra-rewrite-engine/src/main/java/org/apache/shardingsphere/infra/rewrite/engine/GenericSQLRewriteEngine.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-infra%2Fshardingsphere-infra-rewrite%2Fshardingsphere-infra-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Frewrite%2Fengine%2FGenericSQLRewriteEngine.java#L57) | 9 | 11 | 81.82%
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fstatement%2FShardingSpherePreparedStatement.java#L215) | 7 | 9 | 77.78%
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSphereStatement.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fstatement%2FShardingSphereStatement.java#L316) | 4 | 6 | 66.67%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L111) | 0 | 3 | 0.0%
<!-- | **Total:** | **144** | **307** | **46.91%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-features/shardingsphere-replica/shardingsphere-replica-api/src/main/java/org/apache/shardingsphere/replica/api/config/ReplicaRuleConfiguration.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-features%2Fshardingsphere-replica%2Fshardingsphere-replica-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Freplica%2Fapi%2Fconfig%2FReplicaRuleConfiguration.java#L30) | 1 | 0% |
| [shardingsphere-infra/shardingsphere-infra-executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/context/ExecutionContext.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-infra%2Fshardingsphere-infra-executor%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fexecutor%2Fsql%2Fcontext%2FExecutionContext.java#L49) | 1 | 62.5% |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33073638/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L120) | 1 | 16.67% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/33073638) |
| :-- | --: |
| Change from base [Build 14225](https://coveralls.io/builds/33070884): | 0.007% |
| Covered Lines: | 35545 |
| Relevant Lines: | 99970 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] juaby closed pull request #7135: Support multi-replica extension
Posted by GitBox <gi...@apache.org>.
juaby closed pull request #7135:
URL: https://github.com/apache/shardingsphere/pull/7135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] juaby commented on pull request #7135: Support multi-replica extension
Posted by GitBox <gi...@apache.org>.
juaby commented on pull request #7135:
URL: https://github.com/apache/shardingsphere/pull/7135#issuecomment-683320450
https://github.com/apache/shardingsphere/pull/7144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org