[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #123: use openssl provider instead of jdk provider to improve performance

[GitBox <gi...@apache.org>]

DongyuanPan commented on code in PR #123:
URL: https://github.com/apache/rocketmq-mqtt/pull/123#discussion_r922694448


##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java:
##########
@@ -59,7 +59,7 @@ private void initSslContext() {
             InputStream keyStream = new ClassPathResource(KEY_FILE_NAME).getInputStream();
             SslContextBuilder contextBuilder = SslContextBuilder.forServer(certStream, keyStream);
             contextBuilder.clientAuth(ClientAuth.OPTIONAL);
-            contextBuilder.sslProvider(SslProvider.JDK);
+            contextBuilder.sslProvider(SslProvider.OPENSSL);

Review Comment:
   Some environments do not have OpenSSL. At this time, you still need to use JDK SSL.
   OpenSsl.isAvailable() can be used to determine whether OpenSSL is available in the current environment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org