You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@burr.apache.org by eb...@apache.org on 2026/10/17 15:34:35 UTC
(burr) branch main updated: fix(streamlit): read state logs as utf-8 (#907)
This is an automated email from the ASF dual-hosted git repository.
elijahbenizzy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/burr.git
The following commit(s) were added to refs/heads/main by this push:
new 383b1188 fix(streamlit): read state logs as utf-8 (#907)
383b1188 is described below
commit 383b118881c51401bf08936566bc9c9a9eb03f18
Author: Rolly Calma <11...@users.noreply.github.com>
AuthorDate: Sat Oct 17 23:34:30 2026 +0800
fix(streamlit): read state logs as utf-8 (#907)
* fix(streamlit): read state logs as utf-8
* test: isolate streamlit optional dependencies and close log files
* test: explicitly import importlib.util
---
burr/integrations/streamlit.py | 19 +++++----
tests/integrations/test_streamlit.py | 80 ++++++++++++++++++++++++++++++++++++
2 files changed, 90 insertions(+), 9 deletions(-)
diff --git a/burr/integrations/streamlit.py b/burr/integrations/streamlit.py
index 71b63bce..bb9fd9e9 100644
--- a/burr/integrations/streamlit.py
+++ b/burr/integrations/streamlit.py
@@ -95,15 +95,16 @@ def load_state_from_log_file(jsonl_log_file: str, app: Application) -> AppState:
:return: AppState
"""
out = []
- for i, line in enumerate(open(jsonl_log_file)):
- json_line = json.loads(line)
- record = Record(
- state=json_line["state"],
- action=json_line["action"],
- result=json_line["result"]
- # TODO -- add start time, end time
- )
- out.append(record)
+ with open(jsonl_log_file, encoding="utf-8") as log_file:
+ for line in log_file:
+ json_line = json.loads(line)
+ record = Record(
+ state=json_line["state"],
+ action=json_line["action"],
+ result=json_line["result"]
+ # TODO -- add start time, end time
+ )
+ out.append(record)
return AppState(display_index=len(out) - 1, history=out, app=app)
diff --git a/tests/integrations/test_streamlit.py b/tests/integrations/test_streamlit.py
new file mode 100644
index 00000000..6f1a3b8a
--- /dev/null
+++ b/tests/integrations/test_streamlit.py
@@ -0,0 +1,80 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import builtins
+import importlib.util
+import json
+import sys
+import types
+from pathlib import Path
+
+
+def test_load_state_from_log_file_reads_utf8(monkeypatch, tmp_path):
+ monkeypatch.setitem(
+ sys.modules,
+ "burr.integrations.hamilton",
+ types.SimpleNamespace(Hamilton=object, StateSource=object),
+ )
+ monkeypatch.setitem(sys.modules, "graphviz", types.SimpleNamespace(Digraph=object))
+ monkeypatch.setitem(sys.modules, "streamlit", types.SimpleNamespace(session_state={}))
+ colors = types.ModuleType("matplotlib.colors")
+ matplotlib = types.ModuleType("matplotlib")
+ matplotlib.colors = colors
+ monkeypatch.setitem(sys.modules, "matplotlib", matplotlib)
+ monkeypatch.setitem(sys.modules, "matplotlib.colors", colors)
+ # Use a temporary module name so stubbed imports cannot leak into later tests.
+ name = "_burr_streamlit_under_test"
+ spec = importlib.util.spec_from_file_location(
+ name, Path(__file__).resolve().parents[2] / "burr/integrations/streamlit.py"
+ )
+ streamlit = importlib.util.module_from_spec(spec)
+ monkeypatch.setitem(sys.modules, name, streamlit)
+ spec.loader.exec_module(streamlit)
+
+ log_file = tmp_path / "state.jsonl"
+ log_file.write_text(
+ json.dumps(
+ {
+ "state": {"message": "café"},
+ "action": "say",
+ "result": {"ok": True},
+ },
+ ensure_ascii=False,
+ )
+ + "\n",
+ encoding="utf-8",
+ )
+
+ real_open = builtins.open
+ opened = []
+
+ def guarded_open(*args, **kwargs):
+ assert kwargs.get("encoding") == "utf-8"
+ handle = real_open(*args, **kwargs)
+ opened.append(handle)
+ return handle
+
+ monkeypatch.setattr(builtins, "open", guarded_open)
+
+ app = object()
+ state = streamlit.load_state_from_log_file(str(log_file), app)
+
+ assert state.app is app
+ assert state.history[0].state == {"message": "café"}
+ assert state.history[0].action == "say"
+ assert state.history[0].result == {"ok": True}
+ assert opened and all(handle.closed for handle in opened)