[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

[GitBox <gi...@apache.org>]

harleyjj commented on a change in pull request #6333:
URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r541846547



##########
File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js
##########
@@ -65,10 +55,29 @@ export default Component.extend({
    */
   onSelection: null, // function (Set, state)
 
+  context: null,
+
+  compareMode: null, // ""
+
+  didReceiveAttrs() {
+    const context = get(this, 'context');
+
+    set(this, 'compareMode', (context || {}).compareMode);
+  },
+
   //
   // internal properties
   //
 
+  /**
+   * Columns for metrics table
+   * @type Object[]
+   */
+  metricsTableColumns: computed('compareMode', function () {
+    const compareMode = get(this, 'compareMode');
+    return compareMode === 'forecast' ? METRIC_FUNNEL_COLUMNS : METRICS_TABLE_COLUMNS;

Review comment:
       Yes, but only if the user clicks on the Metrics tab.  Do we want it to automatically select the Metrics table when the user selects forecast?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org