You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/11/29 02:10:43 UTC
[bookkeeper] branch master updated: [RELEASE] fix docker mount
volume issue
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new b0708b5 [RELEASE] fix docker mount volume issue
b0708b5 is described below
commit b0708b58f9d6490ed4e47ec688067bebdeb121aa
Author: Sijie Guo <gu...@gmail.com>
AuthorDate: Wed Nov 28 18:10:38 2018 -0800
[RELEASE] fix docker mount volume issue
Descriptions of the changes in this PR:
* Motivation
#1674 introduced a regression for running release scripts on mac.
the destination should be "/home/${USER}" rather than ${LOCAL_HOME}.
because the docker os is linux. Otherwise the gpg keys can not propagated
correctly from host machine to docker.
* Changes
Use `/home/${USER}` as the destination path
Reviewers: Jia Zhai <None>
This closes #1845 from sijie/fix_release_scripts
---
dev/release/000-run-docker.sh | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/dev/release/000-run-docker.sh b/dev/release/000-run-docker.sh
index d63e222..259b46e 100755
--- a/dev/release/000-run-docker.sh
+++ b/dev/release/000-run-docker.sh
@@ -41,12 +41,10 @@ if [ "$(uname -s)" == "Linux" ]; then
USER_NAME=${SUDO_USER:=$USER}
USER_ID=$(id -u "${USER_NAME}")
GROUP_ID=$(id -g "${USER_NAME}")
- LOCAL_HOME="/home/${USER_NAME}"
else # boot2docker uid and gid
USER_NAME=$USER
USER_ID=1000
GROUP_ID=50
- LOCAL_HOME="/Users/${USER_NAME}"
fi
docker build -t "${IMAGE_NAME}-${USER_NAME}" - <<UserSpecificDocker
@@ -108,7 +106,7 @@ docker run -i -t \
-w ${BOOKKEEPER_ROOT} \
-u "${USER}" \
-v "$(realpath $BOOKKEEPER_ROOT):${BOOKKEEPER_ROOT}" \
- -v "$(realpath ~):${LOCAL_HOME}" \
+ -v "$(realpath ~):/home/${USER_NAME}" \
-e VERSION=${VERSION} \
-e MAJOR_VERSION=${MAJOR_VERSION} \
-e NEXT_VERSION=${NEXT_VERSION} \