You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/16 09:18:07 UTC
[GitHub] [flink] tsreaper commented on a change in pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
tsreaper commented on a change in pull request #16792:
URL: https://github.com/apache/flink/pull/16792#discussion_r689371465
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/print/table/PrintTableSinkFactory.java
##########
@@ -113,19 +125,35 @@ public ChangelogMode getChangelogMode(ChangelogMode requestedMode) {
@Override
public SinkRuntimeProvider getSinkRuntimeProvider(DynamicTableSink.Context context) {
DataStructureConverter converter = context.createDataStructureConverter(type);
+ staticPartitions.forEach(
+ (key, value) -> {
+ printIdentifier = null != printIdentifier ? printIdentifier + ":" : "";
+ printIdentifier += key + "=" + value;
+ });
Review comment:
These changes are not covered. Consider adding a test in `PrintConnectorITCase` so that the result shows this `printIdentifier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org