[GitHub] [kafka] divijvaidya opened a new pull request, #12623: MINOR: Fix ConsumerPerformanceTest to work with non-default locales

[GitBox <gi...@apache.org>]

divijvaidya opened a new pull request, #12623:
URL: https://github.com/apache/kafka/pull/12623

   **Problem**
   `ConsumerPerformanceTest` fails when running on a machine with a Locale where decimal is represented by a comma. E.g. in locale of Germany, one point 2 is written as `1,2` and not `1.2` as with the default locale.
   
   The test fails because it validates that each header has a corresponding value by assuming that comma is a separator between values & headers. This assumption fails for Germany Locale because comma could be part of a float number.
   
   **Fix**
   This change introduces a minor fix to change the validation. Instead of separating the attributes using a comma, now we use comma<space> as a separator.
   
   **Bonus fix**
   Close the stream after it is not required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #12623: MINOR: Fix ConsumerPerformanceTest to work with non-default locales

[GitBox <gi...@apache.org>]

dajac merged PR #12623:
URL: https://github.com/apache/kafka/pull/12623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org