You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Teruyoshi Zenmyo (JIRA)" <ji...@apache.org> on 2018/07/02 10:22:00 UTC
[jira] [Commented] (CALCITE-2363) Refactor RelShuttle not to depend
on structures of RelNodes
[ https://issues.apache.org/jira/browse/CALCITE-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529669#comment-16529669 ]
Teruyoshi Zenmyo commented on CALCITE-2363:
-------------------------------------------
Thanks [~julianhyde] for checking.
I'd like to modify the PR to keep backward compatibility.
For keeping the compatibility, I'm considering the refactored version of RelShuttle as a new interface and mark current RelShuttle as deprecated.
Please correct me if this is not good for this project.
> Refactor RelShuttle not to depend on structures of RelNodes
> -----------------------------------------------------------
>
> Key: CALCITE-2363
> URL: https://issues.apache.org/jira/browse/CALCITE-2363
> Project: Calcite
> Issue Type: Improvement
> Reporter: Teruyoshi Zenmyo
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.17.0
>
>
> Currently, RelShuttle implementations depends on the structures of RelNodes.
> For instance, RelShuttleImp.visit(LogicalAggregate aggregate) knows the first element of getInput() is the next element to be visited.
> [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/RelShuttleImpl.java#L75]
>
> By this refactoring, implementations of RelShuttle will become free from invoking super.visit methods.
> https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/CorrelationReferenceFinder.java#L61
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)