You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/05 12:33:14 UTC
[GitHub] [commons-geometry] arturobernalg opened a new pull request #104: [GEOMETRY-103] - Migrate to JUnit 5
arturobernalg opened a new pull request #104:
URL: https://github.com/apache/commons-geometry/pull/104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-geometry] arturobernalg commented on a change in pull request #104: [GEOMETRY-103] - Migrate to JUnit 5
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #104:
URL: https://github.com/apache/commons-geometry/pull/104#discussion_r536883746
##########
File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java
##########
@@ -68,15 +68,15 @@ public static void assertThrows(final Runnable r, final Class<?> exceptionType)
public static void assertThrows(final Runnable r, final Class<?> exceptionType, final String message) {
try {
r.run();
- Assert.fail("Operation should have thrown an exception");
+ Assertions.fail("Operation should have thrown an exception");
Review comment:
Hi @darkma773r ,
I completely agree with you. but, what do you think to do this in a separate jira? as a upgrade?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-geometry] darkma773r commented on a change in pull request #104: [GEOMETRY-103] - Migrate to JUnit 5
Posted by GitBox <gi...@apache.org>.
darkma773r commented on a change in pull request #104:
URL: https://github.com/apache/commons-geometry/pull/104#discussion_r536811344
##########
File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java
##########
@@ -68,15 +68,15 @@ public static void assertThrows(final Runnable r, final Class<?> exceptionType)
public static void assertThrows(final Runnable r, final Class<?> exceptionType, final String message) {
try {
r.run();
- Assert.fail("Operation should have thrown an exception");
+ Assertions.fail("Operation should have thrown an exception");
Review comment:
Could this entire method be replaced with the JUnit assertThrows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-geometry] darkma773r commented on a change in pull request #104: [GEOMETRY-103] - Migrate to JUnit 5
Posted by GitBox <gi...@apache.org>.
darkma773r commented on a change in pull request #104:
URL: https://github.com/apache/commons-geometry/pull/104#discussion_r537061645
##########
File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java
##########
@@ -68,15 +68,15 @@ public static void assertThrows(final Runnable r, final Class<?> exceptionType)
public static void assertThrows(final Runnable r, final Class<?> exceptionType, final String message) {
try {
r.run();
- Assert.fail("Operation should have thrown an exception");
+ Assertions.fail("Operation should have thrown an exception");
Review comment:
A separate task sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-geometry] asfgit merged pull request #104: [GEOMETRY-103] - Migrate to JUnit 5
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #104:
URL: https://github.com/apache/commons-geometry/pull/104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org