[jira] [Commented] (IGNITE-8673) Reconcile isClient* methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496961#comment-16496961 ] 

ASF GitHub Bot commented on IGNITE-8673:
----------------------------------------

GitHub user EdShangGG opened a pull request:

    https://github.com/apache/ignite/pull/4104

    IGNITE-8673 Reconcile isClient* methods

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-8673

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4104
    
----
commit c58ea8fffa1cc416c3185129f4242f459ec166bd
Author: EdShangGG <es...@...>
Date:   2018-05-31T17:53:58Z

    IGNITE-8673 Reconcile isClient* methods

----


> Reconcile isClient* methods
> ---------------------------
>
>                 Key: IGNITE-8673
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8673
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Eduard Shangareev
>            Assignee: Eduard Shangareev
>            Priority: Critical
>             Fix For: 2.6
>
>
> Now isClient (Mode, Cache and so on) methods semantic could mean different things:
> -the same as IgniteConfiguration#setClientMode;
> -or the way how a node is connected to cluster (in the ring or not).
> Almost in all cases, we need the first thing, but actually methods could return second.
> For example, ClusterNode.isClient means second, but all of us use as first.
> So, I propose to make all methods return first.
> And if there are places which require second replace them with the usage of forceClientMode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)