You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/14 13:40:38 UTC
[GitHub] [maven] mthmulders opened a new pull request #658: [MNG-7339] Test if Maven can build itself on less OS'es & JDK's
mthmulders opened a new pull request #658:
URL: https://github.com/apache/maven/pull/658
Following this checklist to help us incorporate your contribution quickly and easily:
- [X] Re-using the existing [Jira issue: MNG-7339](https://issues.apache.org/jira/browse/MNG-7339)
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] ~~Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.~~
- [ ] ~~You have run the [Core IT][core-its] successfully.~~
Follow-up on a quick chat that took place on the ASF Slack, this pull request removes the following entities from the build matrix that checks if Maven can build itself:
- macOS
- JDK 11
This brings the size of the build matrix from 9 down to 4.
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] olamy commented on a change in pull request #658: [MNG-7339] Test if Maven can build itself on less OS'es & JDK's
Posted by GitBox <gi...@apache.org>.
olamy commented on a change in pull request #658:
URL: https://github.com/apache/maven/pull/658#discussion_r785053195
##########
File path: .github/workflows/maven_build_itself.yml
##########
@@ -23,8 +23,8 @@ jobs:
build:
strategy:
matrix:
- os: [ubuntu-latest, windows-latest, macOS-latest]
- java: [8, 11, 17]
+ os: [ubuntu-latest, windows-latest]
Review comment:
Why not osx?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #658: [MNG-7339] Test if Maven can build itself on less OS'es & JDK's
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #658:
URL: https://github.com/apache/maven/pull/658#discussion_r785140749
##########
File path: .github/workflows/maven_build_itself.yml
##########
@@ -23,8 +23,8 @@ jobs:
build:
strategy:
matrix:
- os: [ubuntu-latest, windows-latest, macOS-latest]
- java: [8, 11, 17]
+ os: [ubuntu-latest, windows-latest]
Review comment:
This is a secondary check (verifies Maven SNAPSHOT can build itself), doesn't run the full IT suite. I asked [on Slack](https://the-asf.slack.com/archives/C7Q9JB404/p1641824261011800) a couple of days ago and it seemed nobody cared for this particular check to run on OSX. [We do run the full IT's on OSX, though.](https://github.com/apache/maven/blob/master/.github/workflows/maven.yml#L53).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #658: [MNG-7339] Test if Maven can build itself on less OS'es & JDK's
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #658:
URL: https://github.com/apache/maven/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org