You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/24 19:12:26 UTC
[GitHub] [incubator-yunikorn-core] codecov-commenter commented on pull request #141: [YUNIKORN-117] Create event cache for queue and application events
codecov-commenter commented on pull request #141:
URL: https://github.com/apache/incubator-yunikorn-core/pull/141#issuecomment-649013030
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr&el=h1) Report
> Merging [#141](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/42763f5385c7267a89393c488e6cda61fa3716f7&el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `82.37%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 58.95% 59.90% +0.94%
==========================================
Files 62 66 +4
Lines 6208 6402 +194
==========================================
+ Hits 3660 3835 +175
- Misses 2406 2425 +19
Partials 142 142
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/cachetestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NhY2hldGVzdHV0aWxzLmdv) | `61.76% <0.00%> (-3.87%)` | :arrow_down: |
| [pkg/cache/cluster\_info.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NsdXN0ZXJfaW5mby5nbw==) | `2.41% <0.00%> (-0.02%)` | :arrow_down: |
| [pkg/scheduler/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/scheduling\_application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsaW5nX2FwcGxpY2F0aW9uLmdv) | `71.94% <21.42%> (-1.30%)` | :arrow_down: |
| [pkg/metrics/init.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL21ldHJpY3MvaW5pdC5nbw==) | `63.63% <33.33%> (-3.04%)` | :arrow_down: |
| [pkg/metrics/event.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL21ldHJpY3MvZXZlbnQuZ28=) | `78.78% <78.78%> (ø)` | |
| [pkg/events/event\_cache.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL2V2ZW50cy9ldmVudF9jYWNoZS5nbw==) | `96.15% <96.15%> (ø)` | |
| [pkg/cache/node\_info.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfaW5mby5nbw==) | `72.47% <100.00%> (ø)` | |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `100.00% <100.00%> (ø)` | |
| [pkg/events/event\_store.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree#diff-cGtnL2V2ZW50cy9ldmVudF9zdG9yZS5nbw==) | `100.00% <100.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr&el=footer). Last update [3a97cd6...d7952d6](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org