You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Carles-Figuerola <gi...@git.apache.org> on 2015/11/09 18:25:03 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...
GitHub user Carles-Figuerola opened a pull request:
https://github.com/apache/cloudstack/pull/1051
CLOUDSTACK-9048: Fix typo for public network description
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Carles-Figuerola/cloudstack CLOUDSTACK-9048-fix-typo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1051
----
commit 2f5a40065c599fc78658a0898f9c6e6b29d70f51
Author: Carles Figuerola <ca...@orbitz.com>
Date: 2015-11-09T17:18:44Z
CLOUDSTACK-9048: Fix typo for public network description
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1051
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1051#issuecomment-158752800
LGTM, just to be sure run all integration tests against this branch. They all passed.
<img width="1256" alt="screen shot 2015-11-22 at 12 55 37" src="https://cloud.githubusercontent.com/assets/1630096/11323652/72ab39fe-9118-11e5-90a4-ad7a90501740.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1051#issuecomment-155183148
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1051#issuecomment-155444948
LGTM
Trivial fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1051#issuecomment-155180036
lgtm. I am sure native english speaker appreciate this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---