[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #413: Various cleanups to sbt rpm configuration

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #413:
URL: https://github.com/apache/incubator-daffodil/pull/413#discussion_r482292461



##########
File path: daffodil-cli/src/templates/bash-template
##########
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env sh

Review comment:
       Actually, it turns out RPM mangles the shebang line regardless. The only time it won't mangle it is if it's ``#!/usr/bin/sh``, which doesn't exist on ubuntu. Perhaps reverting back to ``#!/bin/sh`` is a better option than ``#!/usr/bin/env sh``.
   
   The name ``bash-template`` is actually requirement from sbt native-packager. That's just the file it expects for unix-like systems. For example, it uses bat-template for windows systems.
   
   Suggested shell changes seem reasonable. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org