You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/15 03:09:22 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #3549: modlib: Always use separate allocation for text and data

yamt opened a new pull request #3549:
URL: https://github.com/apache/incubator-nuttx/pull/3549


   ## Summary
   
   modlib: Always use separate allocation for text and data
   
   Pros:
   
   * Reduce code differences
   * Smaller allocations for !CONFIG_ARCH_USE_MODULE_TEXT
   
   Cons:
   
   * Likely to use more memory for !CONFIG_ARCH_USE_MODULE_TEXT in total
   
   ## Impact
   
   ## Testing
   
   Tested with:
   
   * sim:module on macOS
   * esp32-devkit:nsh + CONFIG_MODULE on qemu


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3549: modlib: Always use separate allocation for text and data

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3549:
URL: https://github.com/apache/incubator-nuttx/pull/3549#issuecomment-820031379


   Thanks, yes, the size will increase a little bit(less 16 bytes)? But, we have more chance to load ELF sucessfully in the fragment case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #3549: modlib: Always use separate allocation for text and data

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #3549:
URL: https://github.com/apache/incubator-nuttx/pull/3549#issuecomment-820136501


   it seems that i need to update CONFIG_BUILD_PROTECTED case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3549: modlib: Always use separate allocation for text and data

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3549:
URL: https://github.com/apache/incubator-nuttx/pull/3549#issuecomment-820031379


   Yes, the size will increase a little bit(less 16 bytes)? But, we have more chance to load ELF sucessfully in the fragment case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3549: modlib: Always use separate allocation for text and data

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3549:
URL: https://github.com/apache/incubator-nuttx/pull/3549


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org