You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/29 18:42:16 UTC

[GitHub] [beam] y1chi commented on a diff in pull request #17498: Add website link log to notify user of pre-build workflow.

y1chi commented on code in PR #17498:
URL: https://github.com/apache/beam/pull/17498#discussion_r862053936


##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -471,10 +471,19 @@ def run_pipeline(self, pipeline, options, pipeline_proto=None):
         options.view_as(WorkerOptions).sdk_container_image = (
             self._default_environment.container_image)
       else:
+        artifacts = environments.python_sdk_dependencies(options)
+        if artifacts and apiclient._use_fnapi(options):
+          _LOGGER.info(
+              "Pipeline has additional dependencies to be installed "
+              "in SDK worker container, consider using the SDK "
+              "container image pre-building workflow to avoid "
+              "repetitive installations. Learn more on "
+              "https://cloud.google.com/dataflow/docs/guides/"
+              "using-custom-containers#prebuild")

Review Comment:
   I prefer use https://cloud.google.com/dataflow/docs within dataflow_runner make https://beam.apache.org/documentation/sdks/python-pipeline-dependencies/ a more runner-agnostic page, WDYT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org