You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/09/16 15:44:35 UTC
[jira] [Commented] (STORM-498) storm-kafka: make ZK connection
timeout configurable in Kafka spout
[ https://issues.apache.org/jira/browse/STORM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135441#comment-14135441 ]
ASF GitHub Bot commented on STORM-498:
--------------------------------------
GitHub user miguno opened a pull request:
https://github.com/apache/incubator-storm/pull/256
STORM-498: make ZK connection timeout configurable in Kafka spout
This change is backwards compatible to the previous semantics because Storm's default.yaml sets the default ZK connection timeout to 15 seconds, which is equal to the previously hardcoded timeout setting in the Kafka spout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/miguno/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #256
----
commit c35badeae24cb271d504e3c4005192493e0de335
Author: Michael G. Noll <mn...@verisign.com>
Date: 2014-09-16T13:27:12Z
STORM-498: make ZK connection timeout configurable in Kafka spout
----
> storm-kafka: make ZK connection timeout configurable in Kafka spout
> -------------------------------------------------------------------
>
> Key: STORM-498
> URL: https://issues.apache.org/jira/browse/STORM-498
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.3-incubating
> Reporter: Michael Noll
> Assignee: Michael Noll
> Priority: Minor
>
> Currently the Kafka spout uses a hardcoded ZK connection timeout of 15 seconds in {{external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java}}:
> {code}
> _curator = CuratorFrameworkFactory.newClient(
> zkStr,
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT)),
> 15000,
> new RetryNTimes(Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_TIMES)),
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_INTERVAL))));
> {code}
> We should make this setting configurable, similar to the ZK session timeout setting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)