You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Francois Loison (JIRA)" <ji...@codehaus.org> on 2008/09/26 12:17:45 UTC
[jira] Created: (MNG-3768) Class folder system dependency doesn't
work anymore
Class folder system dependency doesn't work anymore
---------------------------------------------------
Key: MNG-3768
URL: http://jira.codehaus.org/browse/MNG-3768
Project: Maven 2
Issue Type: Bug
Components: Artifacts and Repositories
Affects Versions: 2.1.0-M1
Environment: Any
Reporter: Francois Loison
My project use system dependencies pointing to class folders.
<dependency>
<groupId>class-folder</groupId>
<artifactId>class-folder</artifactId>
<version>N</version>
<scope>system</scope>
<systemPath>C:/appli/classes</systemPath>
</dependency>
Such class folders dependencies worked fine with maven 2.0.7
They are needed by my project as it relies on a legacy application not packaged into a jar file.
Root cause is located in file DefaultArtifactResolver.java:
if ( !systemFile.isFile() )
{
throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
artifact );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3768) [regression] Class folder system
dependency doesn't work anymore
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3768:
------------------------------
Patch Submitted: [Yes]
> [regression] Class folder system dependency doesn't work anymore
> ----------------------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Fix For: 2.1.0-M2
>
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip, patch-MNG-3768-distribution.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3768) Class folder system dependency doesn't
work anymore
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3768:
-----------------------------------
Attachment: mng-3768.zip
mng-3288.zip
Integrations tests, one for each possible outcome of this.
> Class folder system dependency doesn't work anymore
> ---------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3768) [regression] Class folder system
dependency doesn't work anymore
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MNG-3768.
-----------------------------
Resolution: Won't Fix
Fix Version/s: (was: 2.2.x)
since there's no response and no votes, and the length of time this release has been out there - I think we should stick with the behaviour of MNG-3288
> [regression] Class folder system dependency doesn't work anymore
> ----------------------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip, patch-MNG-3768-distribution.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3768) Class folder system dependency doesn't
work anymore
Posted by "Francois Loison (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=150601#action_150601 ]
Francois Loison commented on MNG-3768:
--------------------------------------
I tested fix OK using integration tests Benjamin provided.
I applied fix on:
components/branches/maven-2.1.x/maven-artifact-manager/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java
I added Benjamin integration tests on:
core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
New test case pass with fix.
I tested also that new test case fails without fix.
Other test results are unchanged with or without fix.
Regards,
François
> Class folder system dependency doesn't work anymore
> ---------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3768) Class folder system dependency doesn't
work anymore
Posted by "Francois Loison (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francois Loison updated MNG-3768:
---------------------------------
Attachment: MNG-3768.patch.txt
Patch proposal correcting issue.
> Class folder system dependency doesn't work anymore
> ---------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Attachments: MNG-3768.patch.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3768) [regression] Class folder system
dependency doesn't work anymore
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3768:
------------------------------
Fix Version/s: 2.1.0-M2
Summary: [regression] Class folder system dependency doesn't work anymore (was: Class folder system dependency doesn't work anymore)
> [regression] Class folder system dependency doesn't work anymore
> ----------------------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Fix For: 2.1.0-M2
>
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip, patch-MNG-3768-distribution.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3768) [regression] Class folder system
dependency doesn't work anymore
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3768:
------------------------------
Patch Submitted: (was: [Yes])
> [regression] Class folder system dependency doesn't work anymore
> ----------------------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Fix For: 2.0.x
>
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip, patch-MNG-3768-distribution.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3768) [regression] Class folder system
dependency doesn't work anymore
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=164216#action_164216 ]
Brett Porter commented on MNG-3768:
-----------------------------------
Francois... when I apply that patch, 3288 still fails. The cases are certainly incompatible.
Is there really no way you can package those classes into an artifact?
> [regression] Class folder system dependency doesn't work anymore
> ----------------------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Fix For: 2.1.0-M2
>
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip, patch-MNG-3768-distribution.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3768) Class folder system dependency doesn't
work anymore
Posted by "Francois Loison (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=149115#action_149115 ]
Francois Loison commented on MNG-3768:
--------------------------------------
Ok, I'll test the 2 integration tests you wrote and a a specific test for this use case.
Regards,
François
> Class folder system dependency doesn't work anymore
> ---------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3768) [regression] Class folder system
dependency doesn't work anymore
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3768:
------------------------------
Fix Version/s: (was: 2.1.0-M2)
2.0.x
> [regression] Class folder system dependency doesn't work anymore
> ----------------------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Fix For: 2.0.x
>
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip, patch-MNG-3768-distribution.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3768) Class folder system dependency doesn't
work anymore
Posted by "Francois Loison (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francois Loison updated MNG-3768:
---------------------------------
Attachment: patch-MNG-3768-distribution.txt
Patch for bug MNG-3768 applicable to http://svn.apache.org/repos/asf/maven/components/branches/maven-2.1.x
> Class folder system dependency doesn't work anymore
> ---------------------------------------------------
>
> Key: MNG-3768
> URL: http://jira.codehaus.org/browse/MNG-3768
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.1.0-M1
> Environment: Any
> Reporter: Francois Loison
> Attachments: mng-3288.zip, MNG-3768.patch.txt, mng-3768.zip, patch-MNG-3768-distribution.txt
>
>
> My project use system dependencies pointing to class folders.
> <dependency>
> <groupId>class-folder</groupId>
> <artifactId>class-folder</artifactId>
> <version>N</version>
> <scope>system</scope>
> <systemPath>C:/appli/classes</systemPath>
> </dependency>
> Such class folders dependencies worked fine with maven 2.0.7
> They are needed by my project as it relies on a legacy application not packaged into a jar file.
> Root cause is located in file DefaultArtifactResolver.java:
> if ( !systemFile.isFile() )
> {
> throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile,
> artifact );
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira