You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/29 19:25:07 UTC

[GitHub] [beam] jrmccluskey commented on a diff in pull request #22534: Remove stringx package

jrmccluskey commented on code in PR #22534:
URL: https://github.com/apache/beam/pull/22534#discussion_r933560159


##########
sdks/go/examples/native_wordcap/wordcap.go:
##########
@@ -50,6 +49,11 @@ var (
 	}
 )
 
+// FromBytes converts a byte slice to a string.
+func FromBytes(b []byte) string {

Review Comment:
   Is there a reason you fully redefined the function here and then put it in-line in the ParDo?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org